Don't attempt to use hardware video decoding if mf.dll doesn't exist.

Don't attempt to use hardware video decoding if mf.dll doesn't exist.

Media Foundation is missing on Windows N, so attempting to use it will
crash the GPU process.

BUG=638747
Committed: https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62
Cr-Commit-Position: refs/heads/master@{#412723}

[jbauman, 2016-08-17 23:36:15]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 23:37:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2016-08-18 00:00:10]

jbauman@chromium.org changed reviewers:
+ sandersd@chromium.org

[sandersd (OOO until July 31), 2016-08-18 00:05:59]

lgtm

https://codereview.chromium.org/2256933002/diff/1/media/gpu/dxva_video_decode...
File media/gpu/dxva_video_decode_accelerator_win.cc (right):

https://codereview.chromium.org/2256933002/diff/1/media/gpu/dxva_video_decode...
media/gpu/dxva_video_decode_accelerator_win.cc:158: constexpr const wchar_t*
const kMediaFoundationVideoDecoderDLLs[] = {
This looks rather redundant. Does constexpr not imply any of the rest?

[jbauman, 2016-08-18 00:32:38]

On 2016/08/18 00:05:59, sandersd wrote:
> lgtm
> 
>
https://codereview.chromium.org/2256933002/diff/1/media/gpu/dxva_video_decode...
> File media/gpu/dxva_video_decode_accelerator_win.cc (right):
> 
>
https://codereview.chromium.org/2256933002/diff/1/media/gpu/dxva_video_decode...
> media/gpu/dxva_video_decode_accelerator_win.cc:158: constexpr const wchar_t*
> const kMediaFoundationVideoDecoderDLLs[] = {
> This looks rather redundant. Does constexpr not imply any of the rest?

Based on
http://stackoverflow.com/questions/28845058/constexpr-const-vs-constexpr-vari...
you need at least the first const, and I think the second one makes sense to
make it explicit what's going on.

[commit-bot: I haz the power, 2016-08-18 01:25:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 01:25:13]

Dry run: This issue passed the CQ dry run.

[jbauman, 2016-08-18 01:57:03]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2016-08-18 01:57:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 02:02:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-18 02:05:18]

Description was changed from

==========
Don't attempt to use hardware video decoding if mf.dll doesn't exist.

Media Foundation is missing on Windows N, so attempting to use it will
crash the GPU process.

BUG=638747
==========

to

==========
Don't attempt to use hardware video decoding if mf.dll doesn't exist.

Media Foundation is missing on Windows N, so attempting to use it will
crash the GPU process.

BUG=638747

Committed: https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62
Cr-Commit-Position: refs/heads/master@{#412723}
==========

[commit-bot: I haz the power, 2016-08-18 02:05:19]

Patchset 1 (id:??) landed as
https://crrev.com/bf5100015e3ea13c299c43538e75269ccaeaab62
Cr-Commit-Position: refs/heads/master@{#412723}