Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2256923002: Fix -Wsential warnings (Closed)

Created:
4 years, 4 months ago by Tom (Use chromium acct)
Modified:
4 years, 4 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix -Wsential warnings For some reason, Wsentinel doesn't detect NULL as nullptr on some versions of clang, so just change them to nullptr instead. TBR=erg@chromium.org Committed: https://crrev.com/adf40034f86ab2dea41bf9ee173585d332bb8178 Cr-Commit-Position: refs/heads/master@{#412878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (13 generated)
Tom (Use chromium acct)
4 years, 4 months ago (2016-08-17 23:03:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256923002/1
4 years, 4 months ago (2016-08-18 00:44:35 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-18 00:44:36 UTC) #13
Elliot Glaysher
lgtm
4 years, 4 months ago (2016-08-18 17:10:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256923002/1
4 years, 4 months ago (2016-08-18 17:32:25 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 17:37:56 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 17:44:06 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/adf40034f86ab2dea41bf9ee173585d332bb8178
Cr-Commit-Position: refs/heads/master@{#412878}

Powered by Google App Engine
This is Rietveld 408576698