Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2256913003: Tracing: Add more DCHECKS to get more info on recent test flakiness (Closed)

Created:
4 years, 4 months ago by oystein (OOO til 10th of July)
Modified:
4 years, 4 months ago
Reviewers:
shatch
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tracing: Add more DCHECKS to get more info on recent test flakiness TBR=simonhatch@chromium.org BUG=638744 Committed: https://crrev.com/67b18170c9542318566e14b1ed1bcc371af5b00b Cr-Commit-Position: refs/heads/master@{#412964}

Patch Set 1 #

Patch Set 2 : removed one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M base/trace_event/trace_log.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
oystein (OOO til 10th of July)
ptal
4 years, 4 months ago (2016-08-18 20:07:08 UTC) #1
shatch
lgtm
4 years, 4 months ago (2016-08-18 21:17:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256913003/20001
4 years, 4 months ago (2016-08-18 21:41:45 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 23:00:55 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 23:24:39 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67b18170c9542318566e14b1ed1bcc371af5b00b
Cr-Commit-Position: refs/heads/master@{#412964}

Powered by Google App Engine
This is Rietveld 408576698