tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc - Issue 2256913002: Handling of DependentScopeDeclRefExpr and CXXDependentScopeMemberExpr nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc

Issue 2256913002: Handling of DependentScopeDeclRefExpr and CXXDependentScopeMemberExpr nodes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blink-style-new-clang

Patch Set: Tweaked a comment + fixed a typo. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp ('k') | tools/clang/rewrite_to_chrome_style/tests/fields-original.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc

diff --git a/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc

index faef4ec41c625661bd115cd8c9e2a05783d75349..e0f87b1b685388b8d0cf68da6b75af3e06681277 100644

--- a/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc

+++ b/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc

@@ -145,6 +145,14 @@ struct LifetimeOf {

!kIsGarbageCollected ? kRefCountedLifetime : kGarbageCollectedLifetime;

};

+template <typename T>

+struct GenericHashTraitsBase {

+ // We don't want to capitalize fields in type traits

+ // (i.e. the |value| -> |kValue| rename is undesirable below).

+ // This problem is prevented by IsCallee heuristic.

+ static const int kWeakHandlingFlag = TypeTrait2<T>::value ? 123 : 456;

+};

}; // namespace WTF

void F() {