tools/clang/rewrite_to_chrome_style/tests/function-templates-expected.cc - Issue 2256913002: Handling of DependentScopeDeclRefExpr and CXXDependentScopeMemberExpr nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/function-templates-expected.cc

Issue 2256913002: Handling of DependentScopeDeclRefExpr and CXXDependentScopeMemberExpr nodes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blink-style-new-clang

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp ('K') | « tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp ('k') | tools/clang/rewrite_to_chrome_style/tests/function-templates-original.cc » ('j') | tools/clang/rewrite_to_chrome_style/tests/template-expected.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/rewrite_to_chrome_style/tests/function-templates-expected.cc

diff --git a/tools/clang/rewrite_to_chrome_style/tests/function-templates-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/function-templates-expected.cc

index 69a3349583038f79f237f6503c2bb9ef57f78056..f385c32b1c1b27f4df0cbbe9c1b4dca2dc38ffd8 100644

--- a/tools/clang/rewrite_to_chrome_style/tests/function-templates-expected.cc

+++ b/tools/clang/rewrite_to_chrome_style/tests/function-templates-expected.cc

@@ -21,14 +21,11 @@ class Checked {

public:

template <typename U, typename V>

Checked(const Checked<U, V>& rhs) {

- // This (incorrectly) doesn't get rewritten, since it's not instantiated. In

- // this case, the AST representation contains a bunch of

- // CXXDependentScopeMemberExpr nodes.

- if (rhs.hasOverflowed())

- this->overflowed();

- if (!IsInBounds<T>(rhs.m_value))

- this->overflowed();

- value_ = static_cast<T>(rhs.m_value);

+ if (rhs.HasOverflowed())

+ this->Overflowed();

+ if (!IsInBounds<T>(rhs.value_))

+ this->Overflowed();

+ value_ = static_cast<T>(rhs.value_);

Łukasz Anforowicz 2016/08/17 22:45:09 Ha! This is the "m_" heuristic in effect - seems

}

bool HasOverflowed() const { return false; }