Subzero: Replace pointers to allocation functions in stores

src/IceASanInstrumentation.cpp

 //===- subzero/src/IceASanInstrumentation.cpp - ASan ------------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 347 matching lines @@
   for (SizeT I = 0, Args = Instr->getNumArgs(); I < Args; ++I)
     NewCall->addArg(Instr->getArg(I));
   Context.insert(NewCall);
   Instr->setDeleted();
 }
 
 void ASanInstrumentation::instrumentLoad(LoweringContext &Context,
                                          InstLoad *Instr) {
   Operand *Src = Instr->getSourceAddress();
   if (auto *Reloc = llvm::dyn_cast<ConstantRelocatable>(Src)) {
-    std::string SrcName = Reloc->getName().toStringOrEmpty();
-    assert(!SrcName.empty());
-    StringMap::const_iterator SrcSub = FuncSubstitutions.find(SrcName);
-    if (SrcSub != FuncSubstitutions.end()) {
-      auto *NewSrc = ConstantRelocatable::create(
-          Ctx, Reloc->getType(),
-          RelocatableTuple(Reloc->getOffset(), RelocOffsetArray(0),
-                           Ctx->getGlobalString(SrcSub->second),
-                           Reloc->getEmitString()));
-      auto *NewLoad = InstLoad::create(Context.getNode()->getCfg(),
-                                       Instr->getDest(), NewSrc);
-      Instr->setDeleted();
-      Context.insert(NewLoad);
-      Instr = NewLoad;
-    }
+    auto *NewLoad = InstLoad::create(Context.getNode()->getCfg(),
+                                     Instr->getDest(), instrumentReloc(Reloc));
+    Instr->setDeleted();
+    Context.insert(NewLoad);
+    Instr = NewLoad;
   }
   Constant *Func =
       Ctx->getConstantExternSym(Ctx->getGlobalString("__asan_check_load"));
   instrumentAccess(Context, Instr->getSourceAddress(),
                    typeWidthInBytes(Instr->getDest()->getType()), Func);
 }
 
 void ASanInstrumentation::instrumentStore(LoweringContext &Context,
                                           InstStore *Instr) {
+  Operand *Data = Instr->getData();
+  if (auto *Reloc = llvm::dyn_cast<ConstantRelocatable>(Data)) {
+    auto *NewStore = InstStore::create(
+        Context.getNode()->getCfg(), instrumentReloc(Reloc), Instr->getAddr());
+    Instr->setDeleted();
+    Context.insert(NewStore);
+    Instr = NewStore;
+  }
   Constant *Func =
       Ctx->getConstantExternSym(Ctx->getGlobalString("__asan_check_store"));
   instrumentAccess(Context, Instr->getAddr(),
                    typeWidthInBytes(Instr->getData()->getType()), Func);
 }
 
+ConstantRelocatable *
+ASanInstrumentation::instrumentReloc(ConstantRelocatable *Reloc) {
+  std::string DataName = Reloc->getName().toString();
+  StringMap::const_iterator DataSub = FuncSubstitutions.find(DataName);
+  if (DataSub != FuncSubstitutions.end()) {
+    return ConstantRelocatable::create(
+        Ctx, Reloc->getType(),
+        RelocatableTuple(Reloc->getOffset(), RelocOffsetArray(0),
+                         Ctx->getGlobalString(DataSub->second),
+                         Reloc->getEmitString()));
+  }
+  return Reloc;
+}
+
 void ASanInstrumentation::instrumentAccess(LoweringContext &Context,
                                            Operand *Op, SizeT Size,
                                            Constant *CheckFunc) {
   // Skip redundant checks within basic blocks
   VarSizeMap *Checked = ICE_TLS_GET_FIELD(CheckedVars);
   if (ICE_TLS_GET_FIELD(CurNode) != Context.getNode()) {
     ICE_TLS_SET_FIELD(CurNode, Context.getNode());
     if (Checked == NULL) {
       Checked = new VarSizeMap();
       ICE_TLS_SET_FIELD(CheckedVars, Checked);
@@ skipping 64 matching lines @@
   Call->addArg(Ctx->getConstantSym(0, Ctx->getGlobalString(RzSizesName)));
 }
 
 // TODO(tlively): make this more efficient with swap idiom
 void ASanInstrumentation::finishFunc(Cfg *) {
   ICE_TLS_GET_FIELD(LocalVars)->clear();
   ICE_TLS_GET_FIELD(LocalDtors)->clear();
 }
 
 } // end of namespace Ice