Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2256883004: add padding for icon on advance view (Closed)

Created:
4 years, 4 months ago by ftang
Modified:
4 years, 4 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add padding for icon on advance view BUG=638146 Committed: https://crrev.com/e6b66b8b689b6f2b5ba47a06e6ef6c453434b1c0 Cr-Commit-Position: refs/heads/master@{#412841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
ftang
a simple fix. See bug for screenshot. Thanks
4 years, 4 months ago (2016-08-18 06:12:33 UTC) #4
groby-ooo-7-16
On 2016/08/18 06:12:33, ftang wrote: > a simple fix. See bug for screenshot. Thanks LGTM ...
4 years, 4 months ago (2016-08-18 06:50:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256883004/1
4 years, 4 months ago (2016-08-18 15:37:11 UTC) #9
ftang
On 2016/08/18 06:50:52, groby wrote: > On 2016/08/18 06:12:33, ftang wrote: > > a simple ...
4 years, 4 months ago (2016-08-18 15:37:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 15:41:12 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e6b66b8b689b6f2b5ba47a06e6ef6c453434b1c0 Cr-Commit-Position: refs/heads/master@{#412841}
4 years, 4 months ago (2016-08-18 15:43:54 UTC) #13
groby-ooo-7-16
4 years, 4 months ago (2016-08-18 21:13:37 UTC) #14
Message was sent while issue was closed.
On 2016/08/18 15:37:26, ftang wrote:
> On 2016/08/18 06:50:52, groby wrote:
> > On 2016/08/18 06:12:33, ftang wrote:
> > > a simple fix. See bug for screenshot. Thanks
> > 
> > LGTM - but please fix the formatting, unless git cl format generated this.
> 
> That was generated by git cl --format. I feel pretty strange about that too.

Ah well. I'm favoring just accepting clang format over picking style nits - it
might be wrong, but it will be consistently wrong :)

(I've pinged thakis@ who is involved with clang-format to look if it's a bug,
but that's not affecting this CL)

Powered by Google App Engine
This is Rietveld 408576698