Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2256873002: Revert of DevTools: fix stick to bottom in console viewport (Closed)

Created:
4 years, 4 months ago by lushnikov
Modified:
4 years, 4 months ago
Reviewers:
dgozman, luoe
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Closed with no-op. Another CL with a fix was landed. ======= Revert of DevTools: fix stick to bottom in console viewport (patchset #19 id:350001 of https://codereview.chromium.org/2179123004/ ) Reason for revert: Reverting as this adds 200 ms for evaluation commands in console. Repro: 1. open console 2. evaluate "1" 3. wait for response Original issue's description: > DevTools: fix stick to bottom in console viewport > > BUG=603294 > > Committed: https://crrev.com/47da3b4f70636bbac1d874a6710ee6a5806b5392 > Cr-Commit-Position: refs/heads/master@{#411829} TBR=dgozman@chromium.org,luoe@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=603294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -242 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html View 3 chunks +18 lines, -104 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom-expected.txt View 1 chunk +4 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 8 chunks +2 lines, -83 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js View 9 chunks +11 lines, -34 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
lushnikov
Created Revert of DevTools: fix stick to bottom in console viewport
4 years, 4 months ago (2016-08-17 21:15:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256873002/1
4 years, 4 months ago (2016-08-17 21:16:33 UTC) #3
pfeldman
Can we fix it instead?
4 years, 4 months ago (2016-08-17 21:18:43 UTC) #5
luoe
4 years, 4 months ago (2016-08-17 23:06:03 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698