Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2256863004: Add missing Observatory sources to gypi and re-sort. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
cbernaschina
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M runtime/observatory/observatory_sources.gypi View 1 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 4 months ago (2016-08-18 21:51:32 UTC) #3
cbernaschina
On 2016/08/18 21:51:32, rmacnak wrote: lgtm
4 years, 4 months ago (2016-08-18 21:53:40 UTC) #4
rmacnak
4 years, 4 months ago (2016-08-18 21:54:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
01f8ac6d795abab0596331cecdb431d326fb3894 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698