Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2256853003: [heap] Introduce hard limit for external memory (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Introduce hard limit for external memory We introduce, similar to regular heap, a hard and a soft limit for external memory. - Upon reaching the hard limit we do a full GC. The hard limit is a a delta from the size of external memory at last GC. - Upon reaching the soft limit we start incremental marking. Each further AdjustAmountOfExternalMemory will trigger a marking step. The step size depends on how far we are away from the hard limit. Further away means we have still some wiggle room and the step will be small. Being closer to the hard limit makes it more likely to trigger a full GC, so we increase the step size. BUG=chromium:621829 Committed: https://crrev.com/ce66eec800e7329b0967b0f8eec7db05b2b22218 Cr-Commit-Position: refs/heads/master@{#39133}

Patch Set 1 #

Patch Set 2 : Do a memory reducing GC when reaching the hard limit #

Patch Set 3 : Force memory #

Patch Set 4 : ... #

Patch Set 5 : Addressed offline comments #

Patch Set 6 : Delta #

Patch Set 7 : Make it a member on heap so that tests can use the hard limit #

Patch Set 8 : Fix compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -17 lines) Patch
M src/flag-definitions.h View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M src/globals.h View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 6 4 chunks +19 lines, -7 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
Michael Lippautz
ptal
4 years, 3 months ago (2016-09-01 08:30:03 UTC) #2
Michael Lippautz
updated
4 years, 3 months ago (2016-09-01 15:08:52 UTC) #3
ulan
lgtm
4 years, 3 months ago (2016-09-02 11:00:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256853003/140001
4 years, 3 months ago (2016-09-02 12:10:38 UTC) #21
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 3 months ago (2016-09-02 12:12:39 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 12:13:21 UTC) #24
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/ce66eec800e7329b0967b0f8eec7db05b2b22218
Cr-Commit-Position: refs/heads/master@{#39133}

Powered by Google App Engine
This is Rietveld 408576698