Use CSS3 style matching on Android.

Use CSS3 style matching on Android.

Android framework doesn't really use this, the largest user is Chromium.
At the moment this doesn't resolve oblique requests in a nice way, but
the existing code is somewhat close to CSS3 rules already. Instead of
adding oblique handling manually, just use the existing CSS3 style
matching.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2256843003

Committed: https://skia.googlesource.com/skia/+/0367568d4af6a8ffd75bfd07bcb0172fef415940

[bungeman-skia, 2016-08-18 17:27:58]

Description was changed from

==========
Use CSS3 style matching on Android.

Android framework doesn't really use this, the largest user is Chromium.
At the moment this doesn't resolve oblique requests in a nice way, but
the existing code is somewhat close to CSS3 rules already. Instead of
adding oblique handling manually, just use the existing CSS3 style
matching.
==========

to

==========
Use CSS3 style matching on Android.

Android framework doesn't really use this, the largest user is Chromium.
At the moment this doesn't resolve oblique requests in a nice way, but
the existing code is somewhat close to CSS3 rules already. Instead of
adding oblique handling manually, just use the existing CSS3 style
matching.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2256843003
==========

[bungeman-skia, 2016-08-18 17:28:23]

Description was changed from

==========
Use CSS3 style matching on Android.

Android framework doesn't really use this, the largest user is Chromium.
At the moment this doesn't resolve oblique requests in a nice way, but
the existing code is somewhat close to CSS3 rules already. Instead of
adding oblique handling manually, just use the existing CSS3 style
matching.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2256843003
==========

to

==========
Use CSS3 style matching on Android.

Android framework doesn't really use this, the largest user is Chromium.
At the moment this doesn't resolve oblique requests in a nice way, but
the existing code is somewhat close to CSS3 rules already. Instead of
adding oblique handling manually, just use the existing CSS3 style
matching.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2256843003
==========

[bungeman-skia, 2016-08-18 17:28:56]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 17:29:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 17:54:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 17:54:09]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-08-18 18:23:51]

bungeman@google.com changed reviewers:
+ halcanary@google.com

[hal.canary, 2016-08-18 21:29:27]

lgtm.  less code is always better.

is anyone going to complain about this?

[bungeman-skia, 2016-08-18 21:34:59]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-08-18 21:35:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 21:36:04]

Description was changed from

==========
Use CSS3 style matching on Android.

Android framework doesn't really use this, the largest user is Chromium.
At the moment this doesn't resolve oblique requests in a nice way, but
the existing code is somewhat close to CSS3 rules already. Instead of
adding oblique handling manually, just use the existing CSS3 style
matching.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2256843003
==========

to

==========
Use CSS3 style matching on Android.

Android framework doesn't really use this, the largest user is Chromium.
At the moment this doesn't resolve oblique requests in a nice way, but
the existing code is somewhat close to CSS3 rules already. Instead of
adding oblique handling manually, just use the existing CSS3 style
matching.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2256843003

Committed:
https://skia.googlesource.com/skia/+/0367568d4af6a8ffd75bfd07bcb0172fef415940
==========

[commit-bot: I haz the power, 2016-08-18 21:36:05]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0367568d4af6a8ffd75bfd07bcb0172fef415940

[bungeman-skia, 2016-08-18 21:37:27]

On 2016/08/18 21:29:27, Hal Canary wrote:
> lgtm.  less code is always better.
> 
> is anyone going to complain about this?

Yes. It will fix some website somewhere and someone will complain.

Actually, this new code comes pretty close to the old code, aside from the
motivating oblique issue. There were only a few differences when running the old
code through the FontMgr test (the test_matchStyleCSS3 part).