cc, images: Add auto finish draw class to ensure robustness.

cc, images: Add auto finish draw class to ensure robustness.

This patch makes the code more robust in that it adds a class which
automatically calls image draw finished on exit. This ensures that
any changes to the code (more early outs) won't forget to call that
function.

R=ericrk
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/d0cb7fd1eea261f6a1a6e2853ca6c3618c17d845
Cr-Commit-Position: refs/heads/master@{#413367}

[vmpstr, 2016-08-19 18:41:53]

Description was changed from

==========
cc, images: Add auto finish draw class to ensure robustness.

This patch makes the code more robust in that it adds a class which
automatically calls image draw finished on exit. This ensures that
any changes to the code (more early outs) won't forget to call that
function.

R=ericrk
==========

to

==========
cc, images: Add auto finish draw class to ensure robustness.

This patch makes the code more robust in that it adds a class which
automatically calls image draw finished on exit. This ensures that
any changes to the code (more early outs) won't forget to call that
function.

R=ericrk
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[vmpstr, 2016-08-19 18:42:29]

Please take a look.

[ericrk, 2016-08-19 20:38:43]

lgtm

https://codereview.chromium.org/2256833006/diff/1/cc/tiles/software_image_dec...
File cc/tiles/software_image_decode_controller.cc (right):

https://codereview.chromium.org/2256833006/diff/1/cc/tiles/software_image_dec...
cc/tiles/software_image_decode_controller.cc:80: DrawImage draw_image_;
nit: make these const, as they are only set in the constructor.

also, given that this is restricted in scope, it seems like you can store const
Decoded/DrawImage& rather than copies?

[ericrk, 2016-08-19 20:38:43]

lgtm

lgtm

https://codereview.chromium.org/2256833006/diff/1/cc/tiles/software_image_dec...
File cc/tiles/software_image_decode_controller.cc (right):

https://codereview.chromium.org/2256833006/diff/1/cc/tiles/software_image_dec...
cc/tiles/software_image_decode_controller.cc:80: DrawImage draw_image_;
nit: make these const, as they are only set in the constructor.

also, given that this is restricted in scope, it seems like you can store const
Decoded/DrawImage& rather than copies?

[vmpstr, 2016-08-21 03:59:33]

https://codereview.chromium.org/2256833006/diff/1/cc/tiles/software_image_dec...
File cc/tiles/software_image_decode_controller.cc (right):

https://codereview.chromium.org/2256833006/diff/1/cc/tiles/software_image_dec...
cc/tiles/software_image_decode_controller.cc:80: DrawImage draw_image_;
On 2016/08/19 20:38:43, ericrk wrote:
> nit: make these const, as they are only set in the constructor.
> 
> also, given that this is restricted in scope, it seems like you can store
const
> Decoded/DrawImage& rather than copies?

Done. Did this for the key above as well.

[vmpstr, 2016-08-21 03:59:38]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2016-08-21 03:59:38]

The patchset sent to the CQ was uploaded after l-g-t-m from ericrk@chromium.org
Link to the patchset: https://codereview.chromium.org/2256833006/#ps20001
(title: "update")

[commit-bot: I haz the power, 2016-08-21 03:59:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-21 05:21:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-21 05:23:49]

Description was changed from

==========
cc, images: Add auto finish draw class to ensure robustness.

This patch makes the code more robust in that it adds a class which
automatically calls image draw finished on exit. This ensures that
any changes to the code (more early outs) won't forget to call that
function.

R=ericrk
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc, images: Add auto finish draw class to ensure robustness.

This patch makes the code more robust in that it adds a class which
automatically calls image draw finished on exit. This ensures that
any changes to the code (more early outs) won't forget to call that
function.

R=ericrk
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/d0cb7fd1eea261f6a1a6e2853ca6c3618c17d845
Cr-Commit-Position: refs/heads/master@{#413367}
==========

[commit-bot: I haz the power, 2016-08-21 05:23:50]

Patchset 2 (id:??) landed as
https://crrev.com/d0cb7fd1eea261f6a1a6e2853ca6c3618c17d845
Cr-Commit-Position: refs/heads/master@{#413367}