Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 225683005: fix nacl build using ninja (Closed)

Created:
6 years, 8 months ago by epoger
Modified:
6 years, 8 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

fix nacl build using ninja BUG=skia:2366 NOTREECHECKS=True NOTRY=True TBR=robertphillips Committed: http://code.google.com/p/skia/source/detail?r=14065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gyp/common_conditions.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Committing TBR, because it fixed the trybot
6 years, 8 months ago (2014-04-04 18:15:41 UTC) #1
epoger
The CQ bit was checked by epoger@google.com
6 years, 8 months ago (2014-04-04 18:15:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/225683005/1
6 years, 8 months ago (2014-04-04 18:15:51 UTC) #3
commit-bot: I haz the power
Change committed as 14065
6 years, 8 months ago (2014-04-04 18:16:06 UTC) #4
robertphillips
6 years, 8 months ago (2014-04-04 18:56:27 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698