Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 225683002: Revert of Fix power measurement with dumpsys when the format is unrecognized. (Closed)

Created:
6 years, 8 months ago by nhiroki
Modified:
6 years, 8 months ago
Reviewers:
tonyg, qsr
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Revert of Fix power measurement with dumpsys when the format is unrecognized. (https://codereview.chromium.org/225493003/) Reason for revert: This seems to break telemetry_unittests on Mac and Linux. http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%283%29/builds/25648 http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=10049 Original issue's description: > Fix power measurement with dumpsys when the format is unrecognized. > > dumpsys information for older release of android doesn't contain the > needed information. This CL prevent the application to crash in that > case. > > BUG=359883 > TBR=tonyg@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261708 TBR=tonyg@chromium.org,qsr@chromium.org NOTREECHECKS=true NOTRY=true BUG=359883 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -22 lines) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py View 4 chunks +5 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor_unittest.py View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nhiroki
Created Revert of Fix power measurement with dumpsys when the format is unrecognized.
6 years, 8 months ago (2014-04-04 10:22:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/225683002/1
6 years, 8 months ago (2014-04-04 10:22:34 UTC) #2
commit-bot: I haz the power
Change committed as 261725
6 years, 8 months ago (2014-04-04 10:23:56 UTC) #3
qsr
6 years, 8 months ago (2014-04-04 10:57:00 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698