Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2256813003: MD Settings: fix size of broken people icon (Closed)

Created:
4 years, 4 months ago by Dan Beam
Modified:
4 years, 4 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix size of broken people icon R=tommycli@chromium.org BUG=638534 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/176dede85d1478dcb8448063657bd2a3857f3e63 Cr-Commit-Position: refs/heads/master@{#412632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Dan Beam
4 years, 4 months ago (2016-08-17 19:02:47 UTC) #2
Dan Beam
before & after: http://imgur.com/a/yb2H5
4 years, 4 months ago (2016-08-17 19:04:01 UTC) #3
tommycli
On 2016/08/17 19:02:47, Dan Beam wrote: lgtm
4 years, 4 months ago (2016-08-17 19:05:32 UTC) #6
tommycli
On 2016/08/17 19:04:01, Dan Beam wrote: > before & after: http://imgur.com/a/yb2H5 Wait what? How did ...
4 years, 4 months ago (2016-08-17 19:07:07 UTC) #7
Dan Beam
On 2016/08/17 19:07:07, tommycli wrote: > On 2016/08/17 19:04:01, Dan Beam wrote: > > before ...
4 years, 4 months ago (2016-08-17 19:15:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256813003/1
4 years, 4 months ago (2016-08-17 19:16:23 UTC) #11
tommycli
On 2016/08/17 19:15:53, Dan Beam wrote: > On 2016/08/17 19:07:07, tommycli wrote: > > On ...
4 years, 4 months ago (2016-08-17 20:25:14 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 20:58:16 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 21:05:35 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/176dede85d1478dcb8448063657bd2a3857f3e63
Cr-Commit-Position: refs/heads/master@{#412632}

Powered by Google App Engine
This is Rietveld 408576698