Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py

Issue 2256793002: Make docstrings more consistent using format-webkitpy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make indentation of final quote based on parse tree (indentation prior to docstring node) rather th… Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
index 48a8e4d0b82fe7361bbe3405af96f552f2a659ee..2bd265014a2721390c5aee3ad21f01c245d3fc39 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
@@ -78,7 +78,8 @@ class ServerProcess(object):
implements a simple request/response usage model. The primary benefit
is that reading responses takes a deadline, so that we don't ever block
indefinitely. The class also handles transparently restarting processes
- as necessary to keep issuing commands."""
+ as necessary to keep issuing commands.
+ """
def __init__(self, port_obj, name, cmd, env=None, universal_newlines=False, treat_no_data_as_crash=False,
more_logging=False):
@@ -155,7 +156,8 @@ class ServerProcess(object):
def _handle_possible_interrupt(self):
"""This routine checks to see if the process crashed or exited
because of a keyboard interrupt and raises KeyboardInterrupt
- accordingly."""
+ accordingly.
+ """
# FIXME: Linux and Mac set the returncode to -signal.SIGINT if a
# subprocess is killed with a ctrl^C. Previous comments in this
# routine said that supposedly Windows returns 0xc000001d, but that's not what
@@ -166,14 +168,16 @@ class ServerProcess(object):
def poll(self):
"""Check to see if the underlying process is running; returns None
- if it still is (wrapper around subprocess.poll)."""
+ if it still is (wrapper around subprocess.poll).
+ """
if self._proc:
return self._proc.poll()
return None
def write(self, bytes):
"""Write a request to the subprocess. The subprocess is (re-)start()'ed
- if is not already running."""
+ if is not already running.
+ """
if not self._proc:
self._start()
try:

Powered by Google App Engine
This is Rietveld 408576698