third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py - Issue 2256793002: Make docstrings more consistent using format-webkitpy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py

Issue 2256793002: Make docstrings more consistent using format-webkitpy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make indentation of final quote based on parse tree (indentation prior to docstring node) rather th… Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/multiprocessing_bootstrap.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py

index eb63764b530cdf3d819d3a817b26b7bcd2b62c15..cfe05da98904cc7c47af154fa9bd5801ced20592 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py

@@ -126,7 +126,8 @@ class Executive(object):

def kill_process(self, pid):

"""Attempts to kill the given pid.

- Will fail silently if pid does not exist or insufficient permissions."""

+ Will fail silently if pid does not exist or insufficient permissions.

+ """

if sys.platform == "win32":

# We only use taskkill.exe on windows (not cygwin) because subprocess.pid

# is a CYGWIN pid and taskkill.exe expects a windows pid.

@@ -332,7 +333,8 @@ class Executive(object):

def command_for_printing(self, args):

"""Returns a print-ready string representing command args.

- The string should be copy/paste ready for execution in a shell."""

+ The string should be copy/paste ready for execution in a shell.

+ """

args = self._stringify_args(args)

escaped_args = []

for arg in args: