Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2256783002: Simplify embeddability test. (Closed)

Created:
4 years, 4 months ago by bungeman-skia
Modified:
4 years, 4 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simplify embeddability test. There is no reason to read the whole OS/2 table, and no need to spell out the full names of all the types over and over. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2256783002 Committed: https://skia.googlesource.com/skia/+/01a16992cc9297d4985dc80e3177cc7475b9b385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M src/core/SkTypeface.cpp View 1 chunk +6 lines, -8 lines 0 comments Download
M src/sfnt/SkOTTable_OS_2.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
bungeman-skia
4 years, 4 months ago (2016-08-17 18:09:07 UTC) #6
bungeman-skia
While looking at the last pdf change around re-organizing embedding, took a look at this ...
4 years, 4 months ago (2016-08-19 14:44:05 UTC) #9
hal.canary
lgtm
4 years, 4 months ago (2016-08-19 15:23:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256783002/1
4 years, 4 months ago (2016-08-19 15:23:12 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 15:45:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/01a16992cc9297d4985dc80e3177cc7475b9b385

Powered by Google App Engine
This is Rietveld 408576698