chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html - Issue 2256773005: MD Settings: Bluetooth: Use CrScrollableBehavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html

Issue 2256773005: MD Settings: Bluetooth: Use CrScrollableBehavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_638377_scrollable_behavior

Patch Set: Improve item focus and fix tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js ('k') | chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html

diff --git a/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html b/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html

index b5b51298e83b95b3f3d158e039bc724db0b8d460..1f843f23defc05513122de20933a3715656f72e1 100644

--- a/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html

+++ b/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html

@@ -22,8 +22,7 @@

}

</style>

- <div class="flex layout horizontal center" dropdown$="[[dropdownOpened]]"

- on-tap="itemTapped_" actionable>

+ <div class="flex layout horizontal center" dropdown$="[[dropdownOpened]]">

[[getDeviceName_(device)]]

</span>

@@ -31,11 +30,9 @@

</iron-icon>

<span hidden$="[[!device.connecting]]">$i18n{bluetoothConnecting}</span>

- <!-- <div on-tap> is usually [actionable], but this on-tap is just to

- prevent triggering |itemTapped_| in the containing div. -->

- <div hidden$="[[!device.paired]]" on-tap="doNothing_">

+ <div hidden$="[[!device.paired]]">

<paper-icon-button icon="cr:more-vert" toggles

- active="{{dropdownOpened}}">

+ active="{{dropdownOpened}}" tabindex$="[[tabindex]]">

</paper-icon-button>

<iron-dropdown opened="{{dropdownOpened}}" on-tap="menuSelected_"

vertical-align="auto" horizontal-align="right">