components/sync/engine_impl/model_type_registry_unittest.cc - Issue 2256733004: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/model_type_registry_unittest.cc

Issue 2256733004: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/sync/device_info/device_info_service.cc ('K') | « components/sync/engine_impl/model_type_registry.cc ('k') | components/sync/engine_impl/model_type_worker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/engine_impl/model_type_registry_unittest.cc

diff --git a/components/sync/engine_impl/model_type_registry_unittest.cc b/components/sync/engine_impl/model_type_registry_unittest.cc

index f5a1b88cd2e44771402363b9f751d751930668cd..405d60b1578b2c2238dac7c883374e72982c94e6 100644

--- a/components/sync/engine_impl/model_type_registry_unittest.cc

+++ b/components/sync/engine_impl/model_type_registry_unittest.cc

@@ -185,14 +185,14 @@ TEST_F(ModelTypeRegistryTest, NonBlockingTypes) {

syncer::THEMES,

MakeActivationContext(

MakeInitialDataTypeState(THEMES),

- base::WrapUnique(new syncer_v2::FakeModelTypeProcessor())));

+ base::MakeUnique<syncer_v2::FakeModelTypeProcessor>()));

EXPECT_EQ(ModelTypeSet(syncer::THEMES), registry()->GetEnabledTypes());

registry()->ConnectType(

syncer::SESSIONS,

MakeActivationContext(

MakeInitialDataTypeState(SESSIONS),

- base::WrapUnique(new syncer_v2::FakeModelTypeProcessor())));

+ base::MakeUnique<syncer_v2::FakeModelTypeProcessor>()));

EXPECT_EQ(ModelTypeSet(syncer::THEMES, syncer::SESSIONS),

registry()->GetEnabledTypes());

@@ -221,7 +221,7 @@ TEST_F(ModelTypeRegistryTest, NonBlockingTypesWithDirectoryTypes) {

syncer::THEMES,

MakeActivationContext(

MakeInitialDataTypeState(THEMES),

- base::WrapUnique(new syncer_v2::FakeModelTypeProcessor())));

+ base::MakeUnique<syncer_v2::FakeModelTypeProcessor>()));

current_types.Put(syncer::THEMES);

EXPECT_EQ(current_types, registry()->GetEnabledTypes());

@@ -235,7 +235,7 @@ TEST_F(ModelTypeRegistryTest, NonBlockingTypesWithDirectoryTypes) {

syncer::SESSIONS,

MakeActivationContext(

MakeInitialDataTypeState(SESSIONS),

- base::WrapUnique(new syncer_v2::FakeModelTypeProcessor())));

+ base::MakeUnique<syncer_v2::FakeModelTypeProcessor>()));

current_types.Put(syncer::SESSIONS);

EXPECT_EQ(current_types, registry()->GetEnabledTypes());