Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 225673003: Return MaybeHandle from GetProperty. (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Return MaybeHandle from GetProperty. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20510

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -95 lines) Patch
M src/api.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/ic.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M src/json-stringifier.h View 4 chunks +14 lines, -9 lines 0 comments Download
M src/objects.h View 1 5 chunks +19 lines, -16 lines 0 comments Download
M src/objects.cc View 1 12 chunks +44 lines, -41 lines 0 comments Download
M src/runtime.cc View 1 2 chunks +11 lines, -11 lines 0 comments Download
M src/stub-cache.cc View 1 5 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 8 months ago (2014-04-04 11:26:46 UTC) #1
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/225673003/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/225673003/diff/1/src/objects.cc#newcode13216 src/objects.cc:13216: result = GetProperty(object, receiver, &lookup, ...
6 years, 8 months ago (2014-04-04 11:52:27 UTC) #2
Yang
https://codereview.chromium.org/225673003/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/225673003/diff/1/src/objects.cc#newcode13216 src/objects.cc:13216: result = GetProperty(object, receiver, &lookup, name, attributes); On 2014/04/04 ...
6 years, 8 months ago (2014-04-04 12:10:15 UTC) #3
Yang
6 years, 8 months ago (2014-04-04 12:25:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20510 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698