Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: cc/layers/layer_impl.cc

Issue 22567004: Ignore should-scroll-on-main-thread if main frame is not scrollable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/layer_impl.h ('k') | cc/layers/scrollbar_layer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer_impl.cc
diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc
index 7abc6c3787fece894077f4d19f6ebcca5a5b634c..f89786a47f72bb0adfa5385f210918008cee1891 100644
--- a/cc/layers/layer_impl.cc
+++ b/cc/layers/layer_impl.cc
@@ -384,9 +384,12 @@ void LayerImpl::ApplySentScrollDeltas() {
InputHandler::ScrollStatus LayerImpl::TryScroll(
gfx::PointF screen_space_point,
- InputHandler::ScrollInputType type) const {
-
- if (should_scroll_on_main_thread()) {
+ InputHandler::ScrollInputType type,
+ bool main_frame_is_scrollable) const {
+ // The reasons forcing use to scroll on the main thread here are applicable
+ // only for main frame scrolling. If we cannot scroll the main frame, then
+ // we can disregard these reasons.
+ if (should_scroll_on_main_thread() && main_frame_is_scrollable) {
TRACE_EVENT_INSTANT0("cc,impl-scroll",
"LayerImpl::TryScroll: Failed ShouldScrollOnMainThread",
TRACE_EVENT_SCOPE_THREAD);
« no previous file with comments | « cc/layers/layer_impl.h ('k') | cc/layers/scrollbar_layer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698