Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Issue 2256673004: Subzero: Added address of bad instruction to error output (Closed)

Created:
4 years, 4 months ago by tlively
Modified:
4 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Added address of bad instruction to error output BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c1d6fd5a053a583bd304e91a90272674ea7df045

Patch Set 1 #

Total comments: 1

Patch Set 2 : Clarified error message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M runtime/szrt_asan.c View 1 5 chunks +10 lines, -7 lines 0 comments Download
M tests_lit/asan_tests/doublefree.ll View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests_lit/asan_tests/errors.ll View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tlively
4 years, 4 months ago (2016-08-18 23:02:59 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/2256673004/diff/1/runtime/szrt_asan.c File runtime/szrt_asan.c (right): https://codereview.chromium.org/2256673004/diff/1/runtime/szrt_asan.c#newcode128 runtime/szrt_asan.c:128: fprintf(stderr, "(__asan_error located at %p)\n", __asan_error); I might ...
4 years, 4 months ago (2016-08-19 00:08:58 UTC) #3
tlively
4 years, 4 months ago (2016-08-19 00:47:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c1d6fd5a053a583bd304e91a90272674ea7df045 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698