Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2256643003: Synchronize certificate profiles with cryptohomed. (Closed)

Created:
4 years, 4 months ago by The one and only Dr. Crash
Modified:
4 years, 4 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, dkrahn+watch_chromium.org, dkalin1, minz_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Synchronize certificate profiles with cryptohomed. Because the value of a certificate profile is sent straight to cryptohomed, it needs to match what is in CertificateProfile in the cryptohomed source code. See CryptohomeClient::AsyncTpmAttestationCreateCertRequest. BUG=624187 TEST=none Committed: https://crrev.com/e66c53c6b1b1c62c4a4f1956cf8898b05bf8fea8 Cr-Commit-Position: refs/heads/master@{#412741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chromeos/attestation/attestation_constants.h View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
The one and only Dr. Crash
4 years, 4 months ago (2016-08-17 21:29:53 UTC) #3
Darren Krahn
Thanks! LGTM
4 years, 4 months ago (2016-08-17 23:43:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256643003/1
4 years, 4 months ago (2016-08-18 03:37:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 04:08:02 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 04:11:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e66c53c6b1b1c62c4a4f1956cf8898b05bf8fea8
Cr-Commit-Position: refs/heads/master@{#412741}

Powered by Google App Engine
This is Rietveld 408576698