Add two more options for the --password-store switch

Add two more options for the --password-store switch

Currently the option "gnome" is ambiguous between Keyring and Libsecret.
The two new options, "gnome-keyring" and "gnome-libsecret" allow
targeting those implementations individually.

Since password manager and OSCrypt both use this switch to select their
backends, the selection logic has been turned into a common util, to
avoid code duplication.

BUG=602624
Committed: https://crrev.com/2f05d7ffa621967ac92a5dcae91173647fc735c4
Cr-Commit-Position: refs/heads/master@{#412540}

[cfroussios, 2016-08-17 09:51:39]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 09:51:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 10:32:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 10:32:37]

Dry run: This issue passed the CQ dry run.

[cfroussios, 2016-08-17 10:59:11]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 10:59:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cfroussios, 2016-08-17 10:59:32]

cfroussios@chromium.org changed reviewers:
+ thestig@chromium.org, vasilii@chromium.org

[cfroussios, 2016-08-17 10:59:33]

vasilii@chromium.org: Please review changes in
chrome/browser/password_manager/password_store_factory.cc

thestig@chromium.org: Please review changes in 
components/os_crypt/*
chrome/common/chrome_switches.cc

[commit-bot: I haz the power, 2016-08-17 11:47:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 11:47:22]

Dry run: This issue passed the CQ dry run.

[vasilii, 2016-08-17 12:10:14]

lgtm

[Lei Zhang, 2016-08-17 14:36:25]

lgtm

https://codereview.chromium.org/2256633002/diff/20001/components/os_crypt/key...
File components/os_crypt/key_storage_util_linux.h (right):

https://codereview.chromium.org/2256633002/diff/20001/components/os_crypt/key...
components/os_crypt/key_storage_util_linux.h:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
Probably good to put the bits in this file inside namespace os_crypt.
"SelectBackend()" is rather generic.

https://codereview.chromium.org/2256633002/diff/20001/components/os_crypt/key...
components/os_crypt/key_storage_util_linux.h:23: // Decide which backend to
target. |command| is checked first. If it does not
Maybe s/command/type/ ?

[cfroussios, 2016-08-17 15:02:19]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 15:02:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cfroussios, 2016-08-17 15:04:33]

Thanks!

https://codereview.chromium.org/2256633002/diff/20001/components/os_crypt/key...
File components/os_crypt/key_storage_util_linux.h (right):

https://codereview.chromium.org/2256633002/diff/20001/components/os_crypt/key...
components/os_crypt/key_storage_util_linux.h:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
On 2016/08/17 14:36:25, Lei Zhang wrote:
> Probably good to put the bits in this file inside namespace os_crypt.
> "SelectBackend()" is rather generic.

Done.

https://codereview.chromium.org/2256633002/diff/20001/components/os_crypt/key...
components/os_crypt/key_storage_util_linux.h:23: // Decide which backend to
target. |command| is checked first. If it does not
On 2016/08/17 14:36:25, Lei Zhang wrote:
> Maybe s/command/type/ ?

Done.

[commit-bot: I haz the power, 2016-08-17 15:49:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 15:49:49]

Dry run: This issue passed the CQ dry run.

[cfroussios, 2016-08-17 15:54:57]

The CQ bit was checked by cfroussios@chromium.org

[cfroussios, 2016-08-17 15:54:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, vasilii@chromium.org
Link to the patchset: https://codereview.chromium.org/2256633002/#ps40001
(title: "feedback")

[commit-bot: I haz the power, 2016-08-17 15:55:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 15:59:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-17 16:00:40]

Description was changed from

==========
Add two more options for the --password-store switch

Currently the option "gnome" is ambiguous between Keyring and Libsecret.
The two new options, "gnome-keyring" and "gnome-libsecret" allow
targeting those implementations individually.

Since password manager and OSCrypt both use this switch to select their
backends, the selection logic has been turned into a common util, to
avoid code duplication.

BUG=602624
==========

to

==========
Add two more options for the --password-store switch

Currently the option "gnome" is ambiguous between Keyring and Libsecret.
The two new options, "gnome-keyring" and "gnome-libsecret" allow
targeting those implementations individually.

Since password manager and OSCrypt both use this switch to select their
backends, the selection logic has been turned into a common util, to
avoid code duplication.

BUG=602624

Committed: https://crrev.com/2f05d7ffa621967ac92a5dcae91173647fc735c4
Cr-Commit-Position: refs/heads/master@{#412540}
==========

[commit-bot: I haz the power, 2016-08-17 16:00:41]

Patchset 3 (id:??) landed as
https://crrev.com/2f05d7ffa621967ac92a5dcae91173647fc735c4
Cr-Commit-Position: refs/heads/master@{#412540}