Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Unified Diff: lib/src/barback/transformer_id.dart

Issue 2256623003: Fix more strong mode errors and warnings. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/asset/dart/serialize/get_input_transform.dart ('k') | lib/src/barback/web_socket_api.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/barback/transformer_id.dart
diff --git a/lib/src/barback/transformer_id.dart b/lib/src/barback/transformer_id.dart
index 0e67d6aedf5a9188e852e9cba6745e01c4b571a1..58688da2ccb8c0b0c862ecaea09e3e8076deefb7 100644
--- a/lib/src/barback/transformer_id.dart
+++ b/lib/src/barback/transformer_id.dart
@@ -80,14 +80,17 @@ class TransformerId {
/// [getAssetId], this doesn't take generated assets into account; it's used
/// to determine transformers' dependencies, which requires looking at files
/// on disk.
- Future<AssetId> getAssetId(Barback barback) {
+ Future<AssetId> getAssetId(Barback barback) async {
if (path != null) {
- return new Future.value(new AssetId(package, 'lib/$path.dart'));
+ return new AssetId(package, 'lib/$path.dart');
}
var transformerAsset = new AssetId(package, 'lib/transformer.dart');
- return barback.getAssetById(transformerAsset).then((_) => transformerAsset)
- .catchError((e) => new AssetId(package, 'lib/$package.dart'),
- test: (e) => e is AssetNotFoundException);
+ try {
+ await barback.getAssetById(transformerAsset);
+ return transformerAsset;
+ } on AssetNotFoundException catch (_) {
+ return new AssetId(package, 'lib/$package.dart');
+ }
}
}
« no previous file with comments | « lib/src/asset/dart/serialize/get_input_transform.dart ('k') | lib/src/barback/web_socket_api.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698