Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4956)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 2256613002: Remove ShowURL/HideURL from OmniboxView and LocationBarView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_search_terms
Patch Set: Mac Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index d9b6d2aaf77c27da4d9fbe11231fc752a486974b..7242a028688e09527a1199c4da22838ae539bafd 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -354,9 +354,6 @@ void OmniboxViewViews::ExecuteCommand(int command_id, int event_flags) {
case IDS_PASTE_AND_GO:
model()->PasteAndGo(GetClipboardText());
return;
- case IDS_SHOW_URL:
- controller()->ShowURL();
- return;
case IDC_EDIT_SEARCH_ENGINES:
location_bar_view_->command_updater()->ExecuteCommand(command_id);
return;
@@ -880,9 +877,6 @@ bool OmniboxViewViews::IsCommandIdEnabled(int command_id) const {
return !read_only() && !GetClipboardText().empty();
if (command_id == IDS_PASTE_AND_GO)
return !read_only() && model()->CanPasteAndGo(GetClipboardText());
- // TODO(treib): Completely remove IDS_SHOW_URL. crbug.com/627747
- if (command_id == IDS_SHOW_URL)
- return false;
return Textfield::IsCommandIdEnabled(command_id) ||
location_bar_view_->command_updater()->IsCommandEnabled(command_id);
}

Powered by Google App Engine
This is Rietveld 408576698