Adding UMA to PreviewsDataSavings

Adding UMA to PreviewsDataSavings

This UMA measures savings, inflation, content length, etc.

BUG=615565
Committed: https://crrev.com/887c3eaec73e864e1b6e237d49912708de6ff89d
Cr-Commit-Position: refs/heads/master@{#417572}

[RyanSturm, 2016-08-19 20:53:27]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 20:54:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 21:03:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 21:03:48]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[RyanSturm, 2016-08-19 21:09:01]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 21:10:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 22:26:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 22:26:54]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2016-08-19 22:31:29]

ryansturm@chromium.org changed reviewers:
+ bengr@chromium.org

[RyanSturm, 2016-08-19 22:31:29]

bengr PTAL @ *

[bengr, 2016-08-23 23:44:27]

lgtm

[RyanSturm, 2016-09-08 18:18:54]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 18:19:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2016-09-08 19:16:24]

ryansturm@chromium.org changed reviewers:
+ asvitkine@chromium.org

[RyanSturm, 2016-09-08 19:16:25]

asvitkine: PTAL @ histograms.xml

[commit-bot: I haz the power, 2016-09-08 20:00:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 20:00:29]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2016-09-08 22:00:26]

asvitkine@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Alexei Svitkine (slow), 2016-09-08 22:00:26]

Rob, can you help review these?

[rkaplow, 2016-09-09 13:24:02]

lgtm

https://codereview.chromium.org/2256603005/diff/60001/components/previews/pre...
File components/previews/previews_data_savings.cc (right):

https://codereview.chromium.org/2256603005/diff/60001/components/previews/pre...
components/previews/previews_data_savings.cc:38:
UMA_HISTOGRAM_COUNTS("Previews.DataSavings.DataSaverDisabled",
just want you to verify the default max for this macro (1000000) is a reasonable
max for this metric

[RyanSturm, 2016-09-09 13:27:53]

On 2016/09/09 13:24:02, rkaplow wrote:
> lgtm
> 
>
https://codereview.chromium.org/2256603005/diff/60001/components/previews/pre...
> File components/previews/previews_data_savings.cc (right):
> 
>
https://codereview.chromium.org/2256603005/diff/60001/components/previews/pre...
> components/previews/previews_data_savings.cc:38:
> UMA_HISTOGRAM_COUNTS("Previews.DataSavings.DataSaverDisabled",
> just want you to verify the default max for this macro (1000000) is a
reasonable
> max for this metric

Since this is for a single page load at most, 1GB is a reasonable lower bound
for the last bucket. Thanks.

[RyanSturm, 2016-09-09 13:28:07]

The CQ bit was checked by ryansturm@chromium.org

[RyanSturm, 2016-09-09 13:28:07]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org
Link to the patchset: https://codereview.chromium.org/2256603005/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-09 13:28:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 13:32:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-09 13:33:44]

Description was changed from

==========
Adding UMA to PreviewsDataSavings

This UMA measures savings, inflation, content length, etc.

BUG=615565
==========

to

==========
Adding UMA to PreviewsDataSavings

This UMA measures savings, inflation, content length, etc.

BUG=615565

Committed: https://crrev.com/887c3eaec73e864e1b6e237d49912708de6ff89d
Cr-Commit-Position: refs/heads/master@{#417572}
==========

[commit-bot: I haz the power, 2016-09-09 13:33:47]

Patchset 4 (id:??) landed as
https://crrev.com/887c3eaec73e864e1b6e237d49912708de6ff89d
Cr-Commit-Position: refs/heads/master@{#417572}