third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp - Issue 2256593002: CSS: <position> parser consumes only potentially valid tokens

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2256593002: CSS: <position> parser consumes only potentially valid tokens (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: references Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/transforms/perspective-origin-parsing.html ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

index 6ad5b1c4e2d4b13fed9eaac5c9cba9fc914378b1..1fe0080cef5a41133217395d1a5e6626b65445e6 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

@@ -4241,10 +4241,8 @@ bool CSSPropertyParser::consumeBackgroundShorthand(const StylePropertyShorthand&

if (property == CSSPropertyBackgroundRepeatX || property == CSSPropertyWebkitMaskRepeatX) {

consumeRepeatStyleComponent(m_range, value, valueY, implicit);

} else if (property == CSSPropertyBackgroundPositionX || property == CSSPropertyWebkitMaskPositionX) {

- CSSParserTokenRange rangeCopy = m_range;

- if (!consumePosition(rangeCopy, m_context.mode(), UnitlessQuirk::Forbid, value, valueY))

+ if (!consumePosition(m_range, m_context.mode(), UnitlessQuirk::Forbid, value, valueY))

continue;

- m_range = rangeCopy;

} else if (property == CSSPropertyBackgroundSize || property == CSSPropertyWebkitMaskSize) {

if (!consumeSlashIncludingWhitespace(m_range))

continue;