Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2256553002:
Measure time spent in StrictMode violations. (Closed)
|
Created:
4 years, 4 months ago by estevenson Modified:
4 years, 4 months ago CC:
chromium-reviews, asvitkine+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMeasure time spent in StrictMode violations.
Add a histogram for measuring the impact of a new StrictMode violation. This histogram is for a pending downstream change.
BUG=638252
Committed: https://crrev.com/25522ab17f6004977247918a7873821815f2f883
Cr-Commit-Position: refs/heads/master@{#412591}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove Yaron from owners. #Messages
Total messages: 16 (7 generated)
estevenson@chromium.org changed reviewers: + wnwen@chromium.org
ptal Peter!
On 2016/08/16 23:19:07, estevenson wrote: > ptal Peter! lgtm You'll want to make it clear in the description that this is for a downstream change as there's no java code to use this. Possibly have the same person review it (asvitkine@) is usually my go-to person for UMA.
Opps forgot comments. Still lgtm % comment. https://codereview.chromium.org/2256553002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2256553002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:510: + <owner>yfriedman@chromium.org</owner> You can be the owner, I don't mind one way or another, and no need to add Yaron.
Description was changed from ========== Measure time spent in StrictMode violations. Add a histogram for measuring the impact of a new StrictMode violation. BUG=638252 ========== to ========== Measure time spent in StrictMode violations. Add a histogram for measuring the impact of a new StrictMode violation. This histogram is for a pending downstream change. BUG=638252 ==========
On 2016/08/17 13:37:35, Peter Wen wrote: > On 2016/08/16 23:19:07, estevenson wrote: > > ptal Peter! > > lgtm > > You'll want to make it clear in the description that this is for a downstream > change as there's no java code to use this. Possibly have the same person review > it (asvitkine@) is usually my go-to person for UMA. Thanks, updated.
estevenson@chromium.org changed reviewers: + asvitkine@chromium.org
ptal asvitkine! https://codereview.chromium.org/2256553002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2256553002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:510: + <owner>yfriedman@chromium.org</owner> On 2016/08/17 13:37:52, Peter Wen wrote: > You can be the owner, I don't mind one way or another, and no need to add Yaron. Done.
lgtm
The CQ bit was checked by estevenson@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wnwen@chromium.org Link to the patchset: https://codereview.chromium.org/2256553002/#ps20001 (title: "Remove Yaron from owners.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Measure time spent in StrictMode violations. Add a histogram for measuring the impact of a new StrictMode violation. This histogram is for a pending downstream change. BUG=638252 ========== to ========== Measure time spent in StrictMode violations. Add a histogram for measuring the impact of a new StrictMode violation. This histogram is for a pending downstream change. BUG=638252 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Measure time spent in StrictMode violations. Add a histogram for measuring the impact of a new StrictMode violation. This histogram is for a pending downstream change. BUG=638252 ========== to ========== Measure time spent in StrictMode violations. Add a histogram for measuring the impact of a new StrictMode violation. This histogram is for a pending downstream change. BUG=638252 Committed: https://crrev.com/25522ab17f6004977247918a7873821815f2f883 Cr-Commit-Position: refs/heads/master@{#412591} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/25522ab17f6004977247918a7873821815f2f883 Cr-Commit-Position: refs/heads/master@{#412591} |
