third_party/WebKit/LayoutTests/http/tests/loading/resources/image-picture-no-download-after-source-removal-frame.html - Issue 2256533002: Remove MediaQueryList listener from removed HTMLSourceElement.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/loading/resources/image-picture-no-download-after-source-removal-frame.html

Issue 2256533002: Remove MediaQueryList listener from removed HTMLSourceElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/loading/resources/image-picture-no-download-after-picture-removal-frame.html ('K') | « third_party/WebKit/LayoutTests/http/tests/loading/resources/image-picture-no-download-after-removal-frame.html ('k') | third_party/WebKit/Source/core/html/HTMLImageElement.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLImageElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <body>

	3 <script>

	4 var imgLoad = function() {

	5 window.pic.removeChild(window.src);
	cbiesinger 2016/08/17 19:32:05 I think you want window.src -> document.getElement I think you want window.src -> document.getElementByid('src')...? Yoav Weiss 2016/08/30 07:37:07 changed Show quoted text On 2016/08/17 19:32:05, cbiesinger wrote: > I think you want window.src -> document.getElementByid('src')...? changed
	6 window.parent.postMessage("shrink", "*");

	7 }

	8

	9 var test = function () {

	10 var entries = performance.getEntriesByType("resource");

	11 var downloadedImages = 0;

	12 for (var i = 0; i < entries.length; ++i) {

	13 var entry = entries[i];

	14 if (entry.name.indexOf("base-image") != -1)

	15 ++downloadedImages;

	16 }

	17 return downloadedImages;

	18 }

	19

	20 window.addEventListener("message", function(msg) {

	21 if (msg.data == "test")

	22 window.parent.postMessage("test_" + test(), "*");

	23 });

	24 </script>

	25 <picture id=pic>

	26 <source id=src srcset="base-image1.png" media="(max-width: 200px)">

	27 <img src="base-image2.png" onload="imgLoad()">

	28 <picture>

	29 </body>

OLD	NEW