Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2256513003: ServiceWorker: Restore CHECK to DCHECK (Closed)

Created:
4 years, 4 months ago by shimazu
Modified:
4 years, 4 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Restore CHECK to DCHECK Enough information has been gathered for debugging, so it's restored. BUG=634222 R=nhiroki Committed: https://crrev.com/8ec4b9245178dfe3761af5fd09da53488d46f356 Cr-Commit-Position: refs/heads/master@{#412446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/browser/service_worker/service_worker_provider_host.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nhiroki
lgtm
4 years, 4 months ago (2016-08-17 01:35:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256513003/1
4 years, 4 months ago (2016-08-17 02:21:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 04:07:33 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 04:10:12 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8ec4b9245178dfe3761af5fd09da53488d46f356
Cr-Commit-Position: refs/heads/master@{#412446}

Powered by Google App Engine
This is Rietveld 408576698