Suppress TSAN Race in TaskSchedulerWorkerPoolCheckTlsReuse

Suppress TSAN Race in TaskSchedulerWorkerPoolCheckTlsReuse

The race condition is expected as we're racing the thread reclaim
logic. ThreadLocalStorage happens to not synchronize anything at the
moment. Adding a lock to synchronize usage of g_tls_destructors won't
actually fix the inherent race condition. In production, it's up the
owner to make sure that any references have cleaned up before
releasing the TLS slot.

Given that ThreadLocalStorage will be getting some locks in the future,
so I expect to be able to remove the suppression once that goes
through.

BUG=638378
Committed: https://crrev.com/ad1893a4eeeb1775709005ad7df0081560fa27d3
Cr-Commit-Position: refs/heads/master@{#412362}

[robliao, 2016-08-16 21:53:05]

Description was changed from

==========
Suppress TSAN Race in TaskSchedulerWorkerPoolCheckTlsReuse

BUG=638378
==========

to

==========
Suppress TSAN Race in TaskSchedulerWorkerPoolCheckTlsReuse

The race condition is expected as we're racing the thread reclaim
logic. ThreadLocalStorage happens to not synchronize anything at the 
moment. Adding a lock to synchronize usage of g_tls_destructors won't 
actually fix the inherent race condition. In production, it's up the 
owner to make sure that any references have cleaned up before 
releasing the TLS slot.

Given that ThreadLocalStorage will be getting some locks in the future,
so I expect to be able to remove the suppression once that goes 
through.

BUG=638378
==========

[robliao, 2016-08-16 21:53:21]

robliao@chromium.org changed reviewers:
+ tommycli@chromium.org

[robliao, 2016-08-16 21:54:00]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 21:54:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-08-16 22:14:45]

lgtm thanks!

[robliao, 2016-08-16 22:20:29]

The CQ bit was unchecked by robliao@chromium.org

[robliao, 2016-08-16 22:20:33]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2016-08-16 22:20:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 22:35:13]

Description was changed from

==========
Suppress TSAN Race in TaskSchedulerWorkerPoolCheckTlsReuse

The race condition is expected as we're racing the thread reclaim
logic. ThreadLocalStorage happens to not synchronize anything at the 
moment. Adding a lock to synchronize usage of g_tls_destructors won't 
actually fix the inherent race condition. In production, it's up the 
owner to make sure that any references have cleaned up before 
releasing the TLS slot.

Given that ThreadLocalStorage will be getting some locks in the future,
so I expect to be able to remove the suppression once that goes 
through.

BUG=638378
==========

to

==========
Suppress TSAN Race in TaskSchedulerWorkerPoolCheckTlsReuse

The race condition is expected as we're racing the thread reclaim
logic. ThreadLocalStorage happens to not synchronize anything at the 
moment. Adding a lock to synchronize usage of g_tls_destructors won't 
actually fix the inherent race condition. In production, it's up the 
owner to make sure that any references have cleaned up before 
releasing the TLS slot.

Given that ThreadLocalStorage will be getting some locks in the future,
so I expect to be able to remove the suppression once that goes 
through.

BUG=638378
==========

[commit-bot: I haz the power, 2016-08-16 22:35:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-16 22:37:44]

Description was changed from

==========
Suppress TSAN Race in TaskSchedulerWorkerPoolCheckTlsReuse

The race condition is expected as we're racing the thread reclaim
logic. ThreadLocalStorage happens to not synchronize anything at the 
moment. Adding a lock to synchronize usage of g_tls_destructors won't 
actually fix the inherent race condition. In production, it's up the 
owner to make sure that any references have cleaned up before 
releasing the TLS slot.

Given that ThreadLocalStorage will be getting some locks in the future,
so I expect to be able to remove the suppression once that goes 
through.

BUG=638378
==========

to

==========
Suppress TSAN Race in TaskSchedulerWorkerPoolCheckTlsReuse

The race condition is expected as we're racing the thread reclaim
logic. ThreadLocalStorage happens to not synchronize anything at the
moment. Adding a lock to synchronize usage of g_tls_destructors won't
actually fix the inherent race condition. In production, it's up the
owner to make sure that any references have cleaned up before
releasing the TLS slot.

Given that ThreadLocalStorage will be getting some locks in the future,
so I expect to be able to remove the suppression once that goes
through.

BUG=638378

Committed: https://crrev.com/ad1893a4eeeb1775709005ad7df0081560fa27d3
Cr-Commit-Position: refs/heads/master@{#412362}
==========

[commit-bot: I haz the power, 2016-08-16 22:37:45]

Patchset 1 (id:??) landed as
https://crrev.com/ad1893a4eeeb1775709005ad7df0081560fa27d3
Cr-Commit-Position: refs/heads/master@{#412362}