Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2256473002: Disable BattOr tests on Mac on the main waterfall (Closed)

Created:
4 years, 4 months ago by charliea (OOO until 10-5)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable BattOr tests on Mac on the main waterfall BUG=638367 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/0f2a0e2bde19a5238b059fff34dc67f63c2d3936 Cr-Commit-Position: refs/heads/master@{#412517}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M tools/perf/benchmarks/battor.py View 1 4 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
charliea (OOO until 10-5)
4 years, 4 months ago (2016-08-16 21:43:54 UTC) #3
aiolos (Not reviewing)
lgtm, although you should check the waterfall after it lands. https://codereview.chromium.org/2256473002/diff/1/tools/perf/benchmarks/battor.py File tools/perf/benchmarks/battor.py (right): https://codereview.chromium.org/2256473002/diff/1/tools/perf/benchmarks/battor.py#newcode40 ...
4 years, 4 months ago (2016-08-16 21:47:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256473002/20001
4 years, 4 months ago (2016-08-16 21:51:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) linux_perf_cq on ...
4 years, 4 months ago (2016-08-16 23:52:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256473002/20001
4 years, 4 months ago (2016-08-17 14:09:09 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 14:13:19 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 14:16:56 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f2a0e2bde19a5238b059fff34dc67f63c2d3936
Cr-Commit-Position: refs/heads/master@{#412517}

Powered by Google App Engine
This is Rietveld 408576698