Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2256463002: Issue 26335. Insert an empty line if the class body is a single line. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Generate empty constructor body. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -98 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 11 chunks +65 lines, -94 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 4 chunks +46 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 4 months ago (2016-08-16 21:39:19 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2256463002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart File pkg/analysis_server/test/services/correction/fix_test.dart (right): https://codereview.chromium.org/2256463002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart#newcode1061 pkg/analysis_server/test/services/correction/fix_test.dart:1061: A.named(int i) { If it has an empty ...
4 years, 4 months ago (2016-08-16 21:58:17 UTC) #2
scheglov
https://codereview.chromium.org/2256463002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart File pkg/analysis_server/test/services/correction/fix_test.dart (right): https://codereview.chromium.org/2256463002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart#newcode1061 pkg/analysis_server/test/services/correction/fix_test.dart:1061: A.named(int i) { On 2016/08/16 21:58:17, Brian Wilkerson wrote: ...
4 years, 4 months ago (2016-08-16 22:13:06 UTC) #3
scheglov
4 years, 4 months ago (2016-08-16 22:13:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
010578b88aa9cdd43bc4b43dcb55ee56a3394f90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698