Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2256413002: Blink-compatible deserialization of "version 0" sparse arrays. (Closed)

Created:
4 years, 4 months ago by jbroman
Modified:
4 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Blink-compatible deserialization of "version 0" sparse arrays. Version 0 dense arrays cannot be deserialized by current Chromium, which suggests that this is not necessary. BUG=chromium:148757 Committed: https://crrev.com/20a8ef0b92604d65f7d2d27be406245588d18b22 Cr-Commit-Position: refs/heads/master@{#38754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -11 lines) Patch
M src/value-serializer.cc View 3 chunks +45 lines, -11 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jbroman
4 years, 4 months ago (2016-08-19 00:16:36 UTC) #6
Jakob Kummerow
lgtm
4 years, 4 months ago (2016-08-19 13:33:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256413002/1
4 years, 4 months ago (2016-08-19 13:38:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 13:39:56 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 13:40:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20a8ef0b92604d65f7d2d27be406245588d18b22
Cr-Commit-Position: refs/heads/master@{#38754}

Powered by Google App Engine
This is Rietveld 408576698