Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2256403002: Adjust MdTextButton border calculation. (Closed)

Created:
4 years, 4 months ago by Evan Stade
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust MdTextButton border calculation. Buttons should normally be 28dp tall. Other scenarios with bigger than usual text require adjustment to that value. BUG=635151 Committed: https://crrev.com/7c4e09087ab718cc98ca7917fa7e27eca359b0b1 Cr-Commit-Position: refs/heads/master@{#413357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -22 lines) Patch
M ui/views/controls/button/md_text_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/md_text_button.cc View 3 chunks +27 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Evan Stade
This is sorta tricky but I did my best to explain in the code. The ...
4 years, 4 months ago (2016-08-18 23:12:15 UTC) #2
sky
Oy! LGTM
4 years, 4 months ago (2016-08-19 03:24:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256403002/1
4 years, 4 months ago (2016-08-21 00:09:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-21 01:06:09 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-21 01:08:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c4e09087ab718cc98ca7917fa7e27eca359b0b1
Cr-Commit-Position: refs/heads/master@{#413357}

Powered by Google App Engine
This is Rietveld 408576698