Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2256393002: Regression test dart:mirrors (Closed)

Created:
4 years, 4 months ago by vsm
Modified:
4 years, 4 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Regression test dart:mirrors About 50 tests pass right now. A bunch more fail. See #199 R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/a5b0087a4d9feee9fd5618239ffd447abe15c5aa

Patch Set 1 #

Patch Set 2 : Remove flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -0 lines) Patch
M karma.conf.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/browser/language_tests.js View 1 chunk +310 lines, -0 lines 0 comments Download
M test/codegen_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vsm
4 years, 4 months ago (2016-08-18 22:47:58 UTC) #3
Jennifer Messerly
lgtm
4 years, 4 months ago (2016-08-19 14:19:58 UTC) #4
vsm
Committed patchset #2 (id:20001) manually as a5b0087a4d9feee9fd5618239ffd447abe15c5aa (presubmit successful).
4 years, 4 months ago (2016-08-19 15:27:29 UTC) #6
Bob Nystrom
4 years, 4 months ago (2016-08-19 15:51:02 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698