Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: blimp/engine/browser_tests/engine_browsertest.cc

Issue 2256363003: Clean up thread handling in Blimp browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: wez feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/browser_tests/blimp_browser_test.cc ('k') | blimp/engine/mojo/blob_channel_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/browser_tests/engine_browsertest.cc
diff --git a/blimp/engine/browser_tests/engine_browsertest.cc b/blimp/engine/browser_tests/engine_browsertest.cc
index 43e04f190b35240f2739934b061a3e09ae52c5af..0128d9e9eeedb517e4454f85d62e9cfb540dd2bb 100644
--- a/blimp/engine/browser_tests/engine_browsertest.cc
+++ b/blimp/engine/browser_tests/engine_browsertest.cc
@@ -70,7 +70,7 @@ IN_PROC_BROWSER_TEST_F(EngineBrowserTest, LoadUrl) {
OnTitleChanged(kDummyTabId, url.GetContent()));
EXPECT_CALL(client_nav_feature_delegate_,
OnTitleChanged(kDummyTabId, "hello"))
- .WillOnce(InvokeWithoutArgs(this, &EngineBrowserTest::QuitRunLoop));
+ .WillOnce(InvokeWithoutArgs(this, &EngineBrowserTest::SignalCompletion));
// Skip assigner. Engine info is already available.
client_session_->ConnectWithAssignment(client::ASSIGNMENT_REQUEST_RESULT_OK,
@@ -81,7 +81,7 @@ IN_PROC_BROWSER_TEST_F(EngineBrowserTest, LoadUrl) {
client_session_->GetNavigationFeature()->NavigateToUrlText(kDummyTabId,
url.spec());
- RunUntilQuit();
+ RunUntilCompletion();
}
} // namespace
« no previous file with comments | « blimp/engine/browser_tests/blimp_browser_test.cc ('k') | blimp/engine/mojo/blob_channel_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698