Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3571)

Unified Diff: blimp/engine/renderer/blob_channel_sender_proxy_unittest.cc

Issue 2256363003: Clean up thread handling in Blimp browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/renderer/blob_channel_sender_proxy_unittest.cc
diff --git a/blimp/engine/renderer/blob_channel_sender_proxy_unittest.cc b/blimp/engine/renderer/blob_channel_sender_proxy_unittest.cc
index 597a35ee9de7d438218aaa5a705f0becf3c74735..2d6910e67a1915cb1e9dbb025fdc05e310b1751b 100644
--- a/blimp/engine/renderer/blob_channel_sender_proxy_unittest.cc
+++ b/blimp/engine/renderer/blob_channel_sender_proxy_unittest.cc
@@ -28,8 +28,10 @@ const char kBlobPayload[] = "bar";
class BlobChannelSenderProxyTest : public testing::Test {
public:
BlobChannelSenderProxyTest()
- : mojo_service_impl_(
- base::MakeUnique<BlobChannelService>(&mock_sender_)) {}
+ : sender_weak_factory_(&mock_sender_),
+ mojo_service_impl_(base::MakeUnique<BlobChannelService>(
+ sender_weak_factory_.GetWeakPtr(),
+ message_loop_.task_runner())) {}
void SetUp() override {
// Set up communication path from the Proxy to a sender mock:
@@ -46,9 +48,10 @@ class BlobChannelSenderProxyTest : public testing::Test {
const std::string blob_id_ = CalculateBlobId(kBlobId);
base::MessageLoop message_loop_;
- std::unique_ptr<BlobChannelService> mojo_service_impl_;
- MockBlobChannelSender mock_sender_;
std::unique_ptr<BlobChannelSenderProxy> blob_channel_sender_proxy_;
+ MockBlobChannelSender mock_sender_;
+ base::WeakPtrFactory<BlobChannelSender> sender_weak_factory_;
+ std::unique_ptr<BlobChannelService> mojo_service_impl_;
private:
DISALLOW_COPY_AND_ASSIGN(BlobChannelSenderProxyTest);

Powered by Google App Engine
This is Rietveld 408576698