Clean up thread handling in Blimp browser tests.

blimp/engine/session/blimp_engine_session.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/engine/session/blimp_engine_session.h"
 
 #include <string>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 118 matching lines @@
   // |net_log|: The log to use for network-related events.
   // |quit_closure|: A closure which will terminate the engine when
   //                 invoked.
   EngineNetworkComponents(net::NetLog* net_log,
                           const base::Closure& quit_closure);
   ~EngineNetworkComponents() override;
 
   // Sets up network components and starts listening for incoming connection.
   // This should be called after all features have been registered so that
   // received messages can be properly handled.
-  void Initialize(const std::string& client_token);
+  void Initialize(scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,

[Wez, 2016/08/19 19:15:50]

nit: Consider replacing the quit_closure ctor parameter with a ui_task_runner
parameter, since EngineNetworkComponents can then post the
MessageLoop:QuitClosure() directly to the UI thread itself.

[Kevin M, 2016/08/19 21:43:33]

I just made NetworkComponents compute the quit closure for itself.

+                  base::WeakPtr<BlobChannelSender> blob_channel_sender,
+                  const std::string& client_token);
 
   uint16_t GetPortForTesting() { return port_; }
 
-  BrowserConnectionHandler* GetBrowserConnectionHandler();
+  BrowserConnectionHandler* connection_handler() {
+    return &connection_handler_;
+  }
+
+  BlobChannelService* blob_channel_service() {
+    return blob_channel_service_.get();
+  }
 
  private:
   // ConnectionHandler implementation.
   void HandleConnection(std::unique_ptr<BlimpConnection> connection) override;
 
   // ConnectionErrorObserver implementation.
   // Signals the engine session that an authenticated connection was
   // terminated.
   void OnConnectionError(int error) override;
 
   net::NetLog* net_log_;
   base::Closure quit_closure_;
   uint16_t port_ = 0;
 
-  std::unique_ptr<BrowserConnectionHandler> connection_handler_;
+  BrowserConnectionHandler connection_handler_;
   std::unique_ptr<EngineAuthenticationHandler> authentication_handler_;
   std::unique_ptr<EngineConnectionManager> connection_manager_;
+  std::unique_ptr<BlobChannelService> blob_channel_service_;
 
   DISALLOW_COPY_AND_ASSIGN(EngineNetworkComponents);
 };
 
 EngineNetworkComponents::EngineNetworkComponents(
     net::NetLog* net_log,
     const base::Closure& quit_closure)
     : net_log_(net_log),
-      quit_closure_(quit_closure),
-      connection_handler_(new BrowserConnectionHandler) {}
+      quit_closure_(quit_closure) {}
 
 EngineNetworkComponents::~EngineNetworkComponents() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
 }
 
-void EngineNetworkComponents::Initialize(const std::string& client_token) {
+void EngineNetworkComponents::Initialize(
+    scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
+    base::WeakPtr<BlobChannelSender> blob_channel_sender,
+    const std::string& client_token) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
   DCHECK(!connection_manager_);
   // Plumb authenticated connections from the authentication handler
   // to |this| (which will then pass it to |connection_handler_|.
   authentication_handler_ =
       base::WrapUnique(new EngineAuthenticationHandler(this, client_token));
 
   // Plumb unauthenticated connections to |authentication_handler_|.
   connection_manager_ = base::WrapUnique(
       new EngineConnectionManager(authentication_handler_.get()));
 
+  blob_channel_service_ =
+      base::MakeUnique<BlobChannelService>(blob_channel_sender, ui_task_runner);
+
   // Adds BlimpTransports to connection_manager_.
   net::IPEndPoint address(GetIPv4AnyAddress(), GetListeningPort());
   TCPEngineTransport* transport = new TCPEngineTransport(address, net_log_);
   connection_manager_->AddTransport(base::WrapUnique(transport));
 
   transport->GetLocalAddress(&address);
   port_ = address.port();
   DVLOG(1) << "Engine port #: " << port_;
 }
 
 void EngineNetworkComponents::HandleConnection(
     std::unique_ptr<BlimpConnection> connection) {
   // Observe |connection| for disconnection events.
   connection->AddConnectionErrorObserver(this);
-  connection_handler_->HandleConnection(std::move(connection));
+  connection_handler_.HandleConnection(std::move(connection));
 }
 
 void EngineNetworkComponents::OnConnectionError(int error) {
   DVLOG(1) << "EngineNetworkComponents::OnConnectionError(" << error << ")";
   quit_closure_.Run();
 }
 
-BrowserConnectionHandler*
-EngineNetworkComponents::GetBrowserConnectionHandler() {
-  return connection_handler_.get();
-}
-
 BlimpEngineSession::BlimpEngineSession(
     std::unique_ptr<BlimpBrowserContext> browser_context,
     net::NetLog* net_log,
     BlimpEngineConfig* engine_config,
     SettingsManager* settings_manager)
     : screen_(new BlimpScreen),
       browser_context_(std::move(browser_context)),
       engine_config_(engine_config),
       settings_manager_(settings_manager),
       settings_feature_(settings_manager_),
       render_widget_feature_(settings_manager_),
       net_components_(
           new EngineNetworkComponents(net_log,
                                       QuitCurrentMessageLoopClosure())) {
   DCHECK(engine_config_);
   DCHECK(settings_manager_);
 
   screen_->UpdateDisplayScaleAndSize(
       kDefaultScaleFactor,
       gfx::Size(kDefaultDisplayWidth, kDefaultDisplayHeight));
   render_widget_feature_.SetDelegate(kDummyTabId, this);
 
   std::unique_ptr<HeliumBlobSenderDelegate> helium_blob_delegate(
       new HeliumBlobSenderDelegate);
   blob_delegate_ = helium_blob_delegate.get();
   blob_channel_sender_ = base::WrapUnique(
       new BlobChannelSenderImpl(base::WrapUnique(new InMemoryBlobCache),
                                 std::move(helium_blob_delegate)));
-  blob_channel_service_ =
-      base::MakeUnique<BlobChannelService>(blob_channel_sender_.get());
   device::GeolocationProvider::SetGeolocationDelegate(
       geolocation_feature_.CreateGeolocationDelegate());
 }
 
 BlimpEngineSession::~BlimpEngineSession() {
   render_widget_feature_.RemoveDelegate(kDummyTabId);
 
   window_tree_host_->GetInputMethod()->RemoveObserver(this);
 
   // Ensure that all tabs are torn down first, since teardown will
@@ skipping 33 matching lines @@
   window_tree_host_->SetBounds(gfx::Rect(screen_->GetPrimaryDisplay().size()));
 
   RegisterFeatures();
 
   // Initialize must only be posted after the RegisterFeature calls have
   // completed.
   content::BrowserThread::PostTask(
       content::BrowserThread::IO, FROM_HERE,
       base::Bind(&EngineNetworkComponents::Initialize,
                  base::Unretained(net_components_.get()),
+                 base::ThreadTaskRunnerHandle::Get(),
+                 blob_channel_sender_->GetWeakPtr(),
                  engine_config_->client_token()));
 }
 
+BlobChannelService* BlimpEngineSession::GetBlobChannelService() {
+  return net_components_->blob_channel_service();
+}
+
 void BlimpEngineSession::GetEnginePortForTesting(
     const GetPortCallback& callback) {
   content::BrowserThread::PostTaskAndReplyWithResult(
       content::BrowserThread::IO, FROM_HERE,
       base::Bind(&EngineNetworkComponents::GetPortForTesting,
                  base::Unretained(net_components_.get())),
       callback);
 }
 
 void BlimpEngineSession::RegisterFeatures() {
   thread_pipe_manager_.reset(
       new ThreadPipeManager(content::BrowserThread::GetTaskRunnerForThread(
                                 content::BrowserThread::IO),
-                            net_components_->GetBrowserConnectionHandler()));
+                            net_components_->connection_handler()));
 
   // Register features' message senders and receivers.
   tab_control_message_sender_ =
       thread_pipe_manager_->RegisterFeature(BlimpMessage::kTabControl, this);
   navigation_message_sender_ =
       thread_pipe_manager_->RegisterFeature(BlimpMessage::kNavigation, this);
   render_widget_feature_.set_render_widget_message_sender(
       thread_pipe_manager_->RegisterFeature(BlimpMessage::kRenderWidget,
                                             &render_widget_feature_));
   render_widget_feature_.set_input_message_sender(
@@ skipping 247 matching lines @@
     parent->AddChild(content);
   content->Show();
 
   tab_ = base::WrapUnique(new Tab(std::move(new_contents), target_tab_id,
                                   &render_widget_feature_,
                                   navigation_message_sender_.get()));
 }
 
 }  // namespace engine
 }  // namespace blimp