Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: ash/pointer_watcher_delegate_aura.cc

Issue 2256343003: Update ui::PointerEvent to support mouse wheel and capture change events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: location, target etc Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/pointer_watcher_delegate_aura_unittest.cc » ('j') | services/ui/ws/event_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/pointer_watcher_delegate_aura.cc
diff --git a/ash/pointer_watcher_delegate_aura.cc b/ash/pointer_watcher_delegate_aura.cc
index 541a2b5643c1d25ef057667b50c2ce1cc5648b45..e106c7a728a050edb48a968c331d29ea6e20aa1b 100644
--- a/ash/pointer_watcher_delegate_aura.cc
+++ b/ash/pointer_watcher_delegate_aura.cc
@@ -7,6 +7,7 @@
#include "ash/shell.h"
#include "ui/aura/client/screen_position_client.h"
#include "ui/aura/window.h"
+#include "ui/display/screen.h"
#include "ui/events/event.h"
#include "ui/events/event_constants.h"
#include "ui/gfx/geometry/point.h"
@@ -44,18 +45,12 @@ void PointerWatcherDelegateAura::RemovePointerWatcher(
}
void PointerWatcherDelegateAura::OnMouseEvent(ui::MouseEvent* event) {
- if (event->type() == ui::ET_MOUSE_CAPTURE_CHANGED) {
- FOR_EACH_OBSERVER(views::PointerWatcher, non_move_watchers_,
- OnMouseCaptureChanged());
- FOR_EACH_OBSERVER(views::PointerWatcher, move_watchers_,
- OnMouseCaptureChanged());
- return;
- }
-
// For compatibility with the mus version, don't send drags.
if (event->type() != ui::ET_MOUSE_PRESSED &&
event->type() != ui::ET_MOUSE_RELEASED &&
- event->type() != ui::ET_MOUSE_MOVED)
+ event->type() != ui::ET_MOUSE_MOVED &&
+ event->type() != ui::ET_MOUSEWHEEL &&
+ event->type() != ui::ET_MOUSE_CAPTURE_CHANGED)
return;
DCHECK(ui::PointerEvent::CanConvertFrom(*event));
@@ -74,10 +69,15 @@ void PointerWatcherDelegateAura::OnTouchEvent(ui::TouchEvent* event) {
gfx::Point PointerWatcherDelegateAura::GetLocationInScreen(
const ui::LocatedEvent& event) const {
- aura::Window* target = static_cast<aura::Window*>(event.target());
- gfx::Point location_in_screen = event.location();
- aura::client::GetScreenPositionClient(target->GetRootWindow())
- ->ConvertPointToScreen(target, &location_in_screen);
+ gfx::Point location_in_screen;
+ if (event.type() == ui::ET_MOUSE_CAPTURE_CHANGED) {
+ location_in_screen = display::Screen::GetScreen()->GetCursorScreenPoint();
+ } else {
+ aura::Window* target = static_cast<aura::Window*>(event.target());
+ location_in_screen = event.location();
+ aura::client::GetScreenPositionClient(target->GetRootWindow())
+ ->ConvertPointToScreen(target, &location_in_screen);
+ }
return location_in_screen;
}
« no previous file with comments | « no previous file | ash/pointer_watcher_delegate_aura_unittest.cc » ('j') | services/ui/ws/event_dispatcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698