Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: mojo/converters/blink/blink_input_events_type_converters.cc

Issue 2256343003: Update ui::PointerEvent to support mouse wheel and capture change events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/converters/blink/blink_input_events_type_converters.cc
diff --git a/mojo/converters/blink/blink_input_events_type_converters.cc b/mojo/converters/blink/blink_input_events_type_converters.cc
index 770eda740954cea0bd69c395e26d2e6ffc9d855f..44098ef1ebccaaead083bc303b0aae2d76fe029a 100644
--- a/mojo/converters/blink/blink_input_events_type_converters.cc
+++ b/mojo/converters/blink/blink_input_events_type_converters.cc
@@ -136,7 +136,7 @@ std::unique_ptr<blink::WebInputEvent> BuildWebKeyboardEvent(
}
std::unique_ptr<blink::WebInputEvent> BuildWebMouseWheelEventFrom(
- const ui::MouseWheelEvent& event) {
+ const ui::PointerEvent& event) {
std::unique_ptr<blink::WebMouseWheelEvent> web_event(
new blink::WebMouseWheelEvent);
web_event->type = blink::WebInputEvent::MouseWheel;
@@ -149,8 +149,8 @@ std::unique_ptr<blink::WebInputEvent> BuildWebMouseWheelEventFrom(
// TODO(rjkroege): Update the following code once Blink supports
// DOM Level 3 wheel events
// (http://www.w3.org/TR/DOM-Level-3-Events/#events-wheelevents)
- web_event->deltaX = event.x_offset();
- web_event->deltaY = event.y_offset();
+ web_event->deltaX = event.pointer_details().offset.x();
+ web_event->deltaY = event.pointer_details().offset.y();
web_event->wheelTicksX = web_event->deltaX / ui::MouseWheelEvent::kWheelDelta;
web_event->wheelTicksY = web_event->deltaY / ui::MouseWheelEvent::kWheelDelta;
@@ -219,8 +219,7 @@ std::unique_ptr<blink::WebInputEvent> BuildWebTouchEvent(
std::unique_ptr<blink::WebInputEvent>
TypeConverter<std::unique_ptr<blink::WebInputEvent>, ui::Event>::Convert(
const ui::Event& event) {
- DCHECK(event.IsKeyEvent() || event.IsPointerEvent() ||
- event.IsMouseWheelEvent());
+ DCHECK(event.IsKeyEvent() || event.IsPointerEvent());
switch (event.type()) {
case ui::ET_POINTER_DOWN:
case ui::ET_POINTER_UP:
@@ -233,8 +232,8 @@ TypeConverter<std::unique_ptr<blink::WebInputEvent>, ui::Event>::Convert(
return BuildWebTouchEvent(*event.AsPointerEvent());
else
return nullptr;
- case ui::ET_MOUSEWHEEL:
- return BuildWebMouseWheelEventFrom(*event.AsMouseWheelEvent());
+ case ui::ET_POINTER_WHEEL_CHANGED:
+ return BuildWebMouseWheelEventFrom(*event.AsPointerEvent());
case ui::ET_KEY_PRESSED:
case ui::ET_KEY_RELEASED:
return BuildWebKeyboardEvent(*event.AsKeyEvent());
« no previous file with comments | « ash/shared/immersive_fullscreen_controller.cc ('k') | mojo/converters/blink/blink_input_events_type_converters_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698