Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: services/ui/ws/event_dispatcher.cc

Issue 2256343003: Update ui::PointerEvent to support mouse wheel and capture change events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/event_dispatcher.cc
diff --git a/services/ui/ws/event_dispatcher.cc b/services/ui/ws/event_dispatcher.cc
index 06c632338126f2ff3003a0152083913836d6ee5e..b3b9cb9986b8d5bc08019a3e43b192f75bdedf5e 100644
--- a/services/ui/ws/event_dispatcher.cc
+++ b/services/ui/ws/event_dispatcher.cc
@@ -52,16 +52,6 @@ bool IsLocationInNonclientArea(const ServerWindow* target,
return true;
}
-uint32_t PointerId(const ui::LocatedEvent& event) {
- if (event.IsPointerEvent())
- return event.AsPointerEvent()->pointer_id();
- if (event.IsMouseWheelEvent())
- return ui::PointerEvent::kMousePointerId;
-
- NOTREACHED();
- return 0;
-}
-
} // namespace
////////////////////////////////////////////////////////////////////////////////
@@ -287,12 +277,9 @@ void EventDispatcher::ProcessEvent(const ui::Event& event,
return;
}
- if (event.IsPointerEvent() || event.IsMouseWheelEvent()) {
- ProcessLocatedEvent(*event.AsLocatedEvent());
- return;
- }
-
- NOTREACHED();
+ DCHECK(event.IsPointerEvent());
+ ProcessPointerEvent(*event.AsPointerEvent());
+ return;
}
void EventDispatcher::ProcessKeyEvent(const ui::KeyEvent& event,
@@ -316,10 +303,9 @@ void EventDispatcher::ProcessKeyEvent(const ui::KeyEvent& event,
EventDispatcherDelegate::AcceleratorPhase::POST);
}
-void EventDispatcher::ProcessLocatedEvent(const ui::LocatedEvent& event) {
- DCHECK(event.IsPointerEvent() || event.IsMouseWheelEvent());
- const bool is_mouse_event =
- event.IsMousePointerEvent() || event.IsMouseWheelEvent();
+void EventDispatcher::ProcessPointerEvent(const ui::PointerEvent& event) {
+ DCHECK(event.IsPointerEvent());
+ const bool is_mouse_event = event.IsMousePointerEvent();
if (is_mouse_event) {
mouse_pointer_last_location_ = event.root_location();
@@ -347,7 +333,7 @@ void EventDispatcher::ProcessLocatedEvent(const ui::LocatedEvent& event) {
return;
}
- const int32_t pointer_id = PointerId(event);
+ const int32_t pointer_id = event.pointer_id();
if (!IsTrackingPointer(pointer_id) ||
!pointer_targets_[pointer_id].is_pointer_down) {
const bool any_pointers_down = AreAnyPointersDown();

Powered by Google App Engine
This is Rietveld 408576698