views: use cross-platform border colors

views: use cross-platform border colors

As part of Harmony work, MacViews should switch from using Cocoa's color scheme
to Harmony's.

BUG=637016
Committed: https://crrev.com/50b71f849f3ac45cb27559878065926902e992f5
Cr-Commit-Position: refs/heads/master@{#415319}

[Elly Fong-Jones, 2016-08-18 19:24:23]

Description was changed from

==========
views: use cross-platform border colors

As part of Harmony work, MacViews should switch from using Cocoa's color scheme
to Harmony's.

BUG=637016
==========

to

==========
views: use cross-platform border colors

As part of Harmony work, MacViews should switch from using Cocoa's color scheme
to Harmony's.

BUG=637016
==========

[Elly Fong-Jones, 2016-08-18 19:24:23]

ellyjones@chromium.org changed reviewers:
+ estade@chromium.org

[Elly Fong-Jones, 2016-08-18 19:24:30]

estade: ptal? :)

[Elly Fong-Jones, 2016-08-22 18:27:53]

Ping? :)

[Evan Stade, 2016-08-22 20:31:56]

On 2016/08/22 18:27:53, Elly Jones wrote:
> Ping? :)

sorry, was ooo Friday.

LGTM --- do you not need/want to gate this on the MD state, i.e.
IsSecondaryUiMaterial?

[Elly Fong-Jones, 2016-08-30 15:59:07]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-08-30 15:59:08]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2256323003/#ps20001
(title: "also use the right CallToActionColor")

[commit-bot: I haz the power, 2016-08-30 15:59:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elly Fong-Jones, 2016-08-30 16:00:06]

On 2016/08/22 20:31:56, Evan Stade wrote:
> On 2016/08/22 18:27:53, Elly Jones wrote:
> > Ping? :)
> 
> sorry, was ooo Friday.
> 
> LGTM --- do you not need/want to gate this on the MD state, i.e.
> IsSecondaryUiMaterial?

Ooh, good call - fixed :) I also changed CallToActionColor to fall back to the
aura color when IsSecondaryUiMaterial(), since that governs the color for
checked radiobuttons/checkboxes.

[Evan Stade, 2016-08-30 16:09:54]

still lgtm

https://codereview.chromium.org/2256323003/diff/20001/ui/native_theme/native_...
File ui/native_theme/native_theme_mac.mm (right):

https://codereview.chromium.org/2256323003/diff/20001/ui/native_theme/native_...
ui/native_theme/native_theme_mac.mm:142: return
ui::MaterialDesignController::IsSecondaryUiMaterial()
seems perhaps worth separating this out, a la:

if (IsSecondaryUiMaterial()) {
  switch(color_id) {
    case foo:
    case bag:
    case bar:
      return GetAuraColor(color_id, this);
  }
}

When that clause becomes always true, we can just move the body into the
existing switch.

But, up to you.

[commit-bot: I haz the power, 2016-08-30 16:42:19]

Description was changed from

==========
views: use cross-platform border colors

As part of Harmony work, MacViews should switch from using Cocoa's color scheme
to Harmony's.

BUG=637016
==========

to

==========
views: use cross-platform border colors

As part of Harmony work, MacViews should switch from using Cocoa's color scheme
to Harmony's.

BUG=637016
==========

[commit-bot: I haz the power, 2016-08-30 16:42:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 16:45:12]

Description was changed from

==========
views: use cross-platform border colors

As part of Harmony work, MacViews should switch from using Cocoa's color scheme
to Harmony's.

BUG=637016
==========

to

==========
views: use cross-platform border colors

As part of Harmony work, MacViews should switch from using Cocoa's color scheme
to Harmony's.

BUG=637016

Committed: https://crrev.com/50b71f849f3ac45cb27559878065926902e992f5
Cr-Commit-Position: refs/heads/master@{#415319}
==========

[commit-bot: I haz the power, 2016-08-30 16:45:13]

Patchset 2 (id:??) landed as
https://crrev.com/50b71f849f3ac45cb27559878065926902e992f5
Cr-Commit-Position: refs/heads/master@{#415319}