Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 22563006: Fixes vertical misalignment of IME autocompletion. (Closed)

Created:
7 years, 4 months ago by Yuki
Modified:
7 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, nona+watch_chromium.org, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Fixes vertical misalignment of IME autocompletion. I partially fixed vertical alignment of views::Textfield, and I'm now working on the same issue of views::Label. However, it will take time. So I'd like to apply this temporary fix to IME autocompletion in Omnibox. This CL puts the Label of IME autocompletion so its baseline is aligned to Omnibox Textfield's baseline. BUG=270442 TEST=Test manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217776

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated based on review comments. #

Total comments: 6

Patch Set 3 : Synced. #

Patch Set 4 : Fixes style and comments, reverts native_textfield_views.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 1 chunk +15 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yuki
Hi Peter, Could you review this CL? We're aiming to launch the IME autocompletion in ...
7 years, 4 months ago (2013-08-09 07:40:02 UTC) #1
Peter Kasting
https://codereview.chromium.org/22563006/diff/1/chrome/browser/ui/views/location_bar/location_bar_view.cc File chrome/browser/ui/views/location_bar/location_bar_view.cc (right): https://codereview.chromium.org/22563006/diff/1/chrome/browser/ui/views/location_bar/location_bar_view.cc#newcode883 chrome/browser/ui/views/location_bar/location_bar_view.cc:883: const int baseline_diff = location_entry_view_->GetBaseline() - Instead of doing ...
7 years, 4 months ago (2013-08-09 19:00:48 UTC) #2
Yuki
https://codereview.chromium.org/22563006/diff/1/chrome/browser/ui/views/location_bar/location_bar_view.cc File chrome/browser/ui/views/location_bar/location_bar_view.cc (right): https://codereview.chromium.org/22563006/diff/1/chrome/browser/ui/views/location_bar/location_bar_view.cc#newcode883 chrome/browser/ui/views/location_bar/location_bar_view.cc:883: const int baseline_diff = location_entry_view_->GetBaseline() - On 2013/08/09 19:00:48, ...
7 years, 4 months ago (2013-08-12 06:30:14 UTC) #3
Peter Kasting
https://codereview.chromium.org/22563006/diff/6001/chrome/browser/ui/views/location_bar/location_bar_view.cc File chrome/browser/ui/views/location_bar/location_bar_view.cc (right): https://codereview.chromium.org/22563006/diff/6001/chrome/browser/ui/views/location_bar/location_bar_view.cc#newcode283 chrome/browser/ui/views/location_bar/location_bar_view.cc:283: const int baseline_diff = location_entry_view_->GetBaseline() - Nit: Add comment ...
7 years, 4 months ago (2013-08-12 19:54:39 UTC) #4
Yuki
https://codereview.chromium.org/22563006/diff/6001/chrome/browser/ui/views/location_bar/location_bar_view.cc File chrome/browser/ui/views/location_bar/location_bar_view.cc (right): https://codereview.chromium.org/22563006/diff/6001/chrome/browser/ui/views/location_bar/location_bar_view.cc#newcode283 chrome/browser/ui/views/location_bar/location_bar_view.cc:283: const int baseline_diff = location_entry_view_->GetBaseline() - On 2013/08/12 19:54:39, ...
7 years, 4 months ago (2013-08-13 05:51:17 UTC) #5
Peter Kasting
LGTM
7 years, 4 months ago (2013-08-14 23:05:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/22563006/15001
7 years, 4 months ago (2013-08-15 05:56:40 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-15 11:16:15 UTC) #8
Message was sent while issue was closed.
Change committed as 217776

Powered by Google App Engine
This is Rietveld 408576698