Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Issue 2256273002: Remove unused Utf8ToUtf16CharacterStream. (Closed)

Created:
4 years, 4 months ago by vogelheim
Modified:
4 years, 4 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused Utf8ToUtf16CharacterStream. - The static method CopyChars was actually used and has been extracted. - It was used in tests, where it's been replaced w/ ExternalOneByteString... - Only one test actually relied on Utf8 handling (as opposed to ASCII only), and that was the test testing Utf8ToUtf16CharacterStream itself. +66 -277 LOC :) BUG=v8:4947 Committed: https://crrev.com/e954e954007b0ebfe2665df64cd1976a68c3f2b9 Cr-Commit-Position: refs/heads/master@{#38824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -277 lines) Patch
M src/parsing/scanner-character-streams.h View 2 chunks +4 lines, -23 lines 0 comments Download
M src/parsing/scanner-character-streams.cc View 4 chunks +39 lines, -159 lines 0 comments Download
M test/cctest/test-parsing.cc View 16 chunks +23 lines, -95 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
vogelheim
4 years, 4 months ago (2016-08-18 15:58:24 UTC) #7
marja
lgtm
4 years, 4 months ago (2016-08-19 08:38:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256273002/1
4 years, 4 months ago (2016-08-23 13:04:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 13:30:29 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 13:30:48 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e954e954007b0ebfe2665df64cd1976a68c3f2b9
Cr-Commit-Position: refs/heads/master@{#38824}

Powered by Google App Engine
This is Rietveld 408576698