Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2256253003: SkFontMgr_android clean up. (Closed)

Created:
4 years, 4 months ago by bungeman-skia
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkFontMgr_android clean up. This removes the never used defaultTypeface, uses 'StyleSet' in field names consistently, fixes potential leaks of names, and moves fields to sk_sp. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2256253003 Committed: https://skia.googlesource.com/skia/+/83b24ff0825eadf200c3b5d87c669beb270a8680

Patch Set 1 #

Patch Set 2 : Rename. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -39 lines) Patch
M src/ports/SkFontMgr_android.cpp View 1 6 chunks +27 lines, -39 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
bungeman-skia
4 years, 4 months ago (2016-08-18 20:58:25 UTC) #8
mtklein
lgtm
4 years, 4 months ago (2016-08-19 12:02:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256253003/20001
4 years, 4 months ago (2016-08-19 12:02:32 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 12:03:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/83b24ff0825eadf200c3b5d87c669beb270a8680

Powered by Google App Engine
This is Rietveld 408576698