Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 225623004: Callers of ElementsAccessor::AddElementsToFixedArray(), ElementsAccessor::HasElement() and Elements… (Closed)

Created:
6 years, 8 months ago by Igor Sheludko
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Callers of ElementsAccessor::AddElementsToFixedArray(), ElementsAccessor::HasElement() and ElementsAccessor::GetKeyForIndex() handlified. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20513

Patch Set 1 #

Patch Set 2 : HasElement() polishing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -70 lines) Patch
M src/builtins.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/elements.h View 1 4 chunks +30 lines, -10 lines 0 comments Download
M src/elements.cc View 1 6 chunks +27 lines, -15 lines 0 comments Download
M src/handles.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/handles.cc View 6 chunks +9 lines, -20 lines 0 comments Download
M src/objects.h View 1 chunk +6 lines, -3 lines 0 comments Download
M src/objects.cc View 2 chunks +17 lines, -11 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 8 months ago (2014-04-04 12:44:06 UTC) #1
Yang
On 2014/04/04 12:44:06, Igor Sheludko wrote: > PTAL lgtm.
6 years, 8 months ago (2014-04-04 12:59:31 UTC) #2
Igor Sheludko
6 years, 8 months ago (2014-04-04 13:05:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20513 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698