Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2256223002: Ensure resolution of metadata on parts for serialization. (Closed)

Created:
4 years, 4 months ago by Johnni Winther
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure resolution of metadata on parts for serialization. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/291af2ee6f428d014afe1c14a125cf49cdadf93a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +5 lines, -0 lines 2 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 4 months ago (2016-08-18 12:03:53 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2256223002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/2256223002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode916 pkg/compiler/lib/src/compiler.dart:916: library.compilationUnits.forEach((CompilationUnitElement unit) { same here - guard to ...
4 years, 4 months ago (2016-08-18 15:30:58 UTC) #3
Johnni Winther
https://codereview.chromium.org/2256223002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/2256223002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode916 pkg/compiler/lib/src/compiler.dart:916: library.compilationUnits.forEach((CompilationUnitElement unit) { On 2016/08/18 15:30:58, Siggi Cherem (dart-lang) ...
4 years, 4 months ago (2016-08-19 08:57:17 UTC) #4
Johnni Winther
4 years, 4 months ago (2016-08-19 09:02:46 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
291af2ee6f428d014afe1c14a125cf49cdadf93a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698